[wix-devs] WiX toolset v4.0: Build Exp

[Rob Mensching]

> What should I do to solve the remaining errors about code-style after using build.cmd?

The WiX Toolset is a very large and much of it was written on .NET Framework v1.0 before the modern style systems were in place. In fact, several of the common styles today were the opposite way back when with early StyleCop.

In the past year or so, .editorconfig has advanced to the point where we can probably encode the full WiX style guide (at least for managed code). We've done a little bit in WiX v4 to test those waters and guide new code. But there is a significant amount of old (untouched in v4) code where you will see plenty of style errors.

My recommendation is as a new participant in the WiX Toolset to filter out the style errors for now and to not create more of them. There will be a time to ensure .editorconfig is perfect and sweep the code. But that day is not today and it is not in v4.

If you are writing new code and have questions about what the correct style to use is, feel free to ask. I know that transition times can lead to confusion.

-----Original Message-----
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of Timofey Evsyutkin via wix-devs
Sent: Wednesday, May 18, 2022 2:30 AM
To: Rob Mensching <rob at firegiant.com>
Cc: Timofey Evsyutkin <goldghost.oomphi.suppository at gmail.com>; WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Subject: Re: [wix-devs] WiX toolset v4.0: Build Exp

Thanks, Rob!

I apologize for my mistake.

> using build.cmd from the root before opening any .sln files
I called it 'build with DCP' (Development Command Prompt).
Thus, it reduces the number of errors as expected.

> To solve what exactly?
What should I do to solve the remaining errors about code-style after using build.cmd?
Are there any VS or ReSharper code style settings files accepted for wix?
or should I set them up manually?
It seems to me that the information here (
https://wixtoolset.org/development/code-style/) is not the most relevant for manually setting code-style options.

ср, 18 мая 2022 г. в 12:30, Rob Mensching <rob at firegiant.com>:

> > What should I do to solve it?
>
> To solve what exactly?
>
> One quick note, you'll want to build using build.cmd from the root 
> before opening any .sln files. That build.cmd will make sure all the 
> (many) dependencies are in place and everything successfully built once.
>
>
> -----Original Message-----
> From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of 
> Timofey Evsyutkin via wix-devs
> Sent: Tuesday, May 17, 2022 9:51 PM
> To: wix-devs at lists.wixtoolset.org
> Cc: Timofey Evsyutkin <goldghost.oomphi.suppository at gmail.com>
> Subject: [wix-devs] WiX toolset v4.0: Build Exp
>
> I'm building and installing the wix toolset from source code.
> After that I'm going to write a brief overview of how to use the user 
> kit and possibly with some describings of common problems and troubleshooting.
> The best way to reach it that i see is a live code in debug mode.
>
> I have done some changes for a head commit of develop-branch in my 
> forked experimental branch here
>
> https://github.com/wixtoolset/wix4/commit/0de2583e401b594399a651c7b705
> 20454d8e0ec2 and i have skipped a Fact 'CanManipulateExtensionCache'
> as a result: locally build is passing
>
> However I'm not sure if this is a good solution that is related to 
> MSBuildSdks.
>
> When I open any solution file in Visual Studio, I encounter some 
> errors, and so I can build nothing. For example, wix.sln.
> Before being built with a DCP for VS 2022, there were 25561 errors in 
> 526 files.
> After being built with a DCP for VS 2022, there are 95 errors in 33 files.
>
> The remaining Errors are related to a code-style and I don't want to 
> fix them. I use Visual Studio 
> (2008/2010/2012/2013/2015/2017/2019/2022),
> ReSharper tools and GhostDoc extension. What should I do to solve it?
>
> --
> Best Regards, Timofey Evsyutkin
> P.H.D., Software Engineer
>
> Tg: @OOMPHi - https://t.me/OOMPHi
>
> CONFIDENTIALITY NOTICE: The information contained in this email and 
> attached document(s) may contain confidential information that is 
> intended only for the addressee(s). If you are not the intended 
> recipient, you are hereby advised that any disclosure, copying, 
> distribution or the taking of any action in reliance upon the 
> information is prohibited. If you have received this email in error, 
> please immediately notify the sender and delete it from your system.
> ____________________________________________________________________
> WiX Toolset Developer Mailing List provided by FireGiant 
> http://www.firegiant.com/
>
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/