[wix-devs] Merge Module Samples

[Christopher Painter]

The votive v3 merge module project template exhibits the problems easily.

I can create a repos if you'd like to see it in situ.

Before:

<?xml version="1.0" encoding="UTF-8"?>
<Wix xmlns="http://schemas.microsoft.com/wix/2006/wi">
      <Module Id="MergeModule1" Language="1033" Version="1.0.0.0">
            <Package Id="7c47c919-2772-4b9d-ab34-d58120ff0d84" Manufacturer="Test" InstallerVersion="200" />

            <Directory Id="TARGETDIR" Name="SourceDir">
                  <Directory Id="MergeRedirectFolder">

                        <!-- TODO: Remove the comments around this Component element in order to add resources to this module. -->
                        <!-- <Component Id="ModuleComponent" Guid="f3c0bd0a-d02f-4bc9-a02c-d1fdf13c194b"> -->
                              <!-- TODO: Insert files, registry keys, and other resources here. -->
                        <!-- </Component> -->

                  </Directory>
            </Directory>
      </Module>
</Wix>

After:

<Wix xmlns="http://wixtoolset.org/schemas/v4/wxs">
      <Module Id="MergeModule1" Language="1033" Version="1.0.0.0" Guid="7c47c919-2772-4b9d-ab34-d58120ff0d84" InstallerVersion="200"><SummaryInformation Manufacturer="Test" />

            
      
                  <Directory Id="MergeRedirectFolder">

                        <!-- TODO: Remove the comments around this Component element in order to add resources to this module. -->
                        <!-- <Component Id="ModuleComponent" Guid="f3c0bd0a-d02f-4bc9-a02c-d1fdf13c194b"> -->
                              <!-- TODO: Insert files, registry keys, and other resources here. -->
                        <!-- </Component> -->

                  </Directory>
            </Module>
</Wix>


________________________________
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> on behalf of Ron Martin via wix-devs <wix-devs at lists.wixtoolset.org>
Sent: Saturday, December 17, 2022 7:24 PM
To: wix-devs <wix-devs at lists.wixtoolset.org>
Cc: Ron Martin <cpuwzd at comcast.net>
Subject: [wix-devs] Merge Module Samples

@chrpai:

Chris, could you please supply one or more samples of module files that
do not convert to your liking?

The issue here seems to be quite different from the one I fixed. I'm
guessing that the the problem you are seeing stems from an attempt to
format a long attribute list. If that is the case, I'll need to come up
with a line folding heuristic. The formatting problem I worked on
previously involved converting inner text to comments and attribute
values, depending on where the deprecated inner text was found. There
were obvious places to remove and insert new-lines, and reasonable
places from which to copy indentations.

The parser places all of an element's attributes in a list, rather than
keeping them in XML nodes. I don't remember exactly where the attributes
are converted back to XML nodes, but that's probably where the fix will
have to go. Unfortunately, this has the potential to affect a lot of
other code paths that might require a lot of work to test
systematically. It will be really good to get this change into RC2, so
that it can get a fair shakedown.

Thanks,

Ron Martin
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/