[wix-devs] Merge Module Samples

[Christopher Painter]

Yup. Here's another example of it injecting a new element that previously didn't exist with wierd formatting.

https://github.com/wixtoolset/issues/issues/7100
[https://opengraph.githubassets.com/cd2b73dd9fef172247b067e20117ba82bfd95e54ba43ad7f67597ea945774f2a/wixtoolset/issues/issues/7100]<https://github.com/wixtoolset/issues/issues/7100>
Conversion to vs:FindVisualStudio isn't 'pretty' · Issue #7100 · wixtoolset/issues<https://github.com/wixtoolset/issues/issues/7100>
vs 17.4.1 hw 0.9.1 wx 4 rc1 Create a project in v3 that uses VS Extension and PropertyRef Id="VS2017_EXTENSIONS_DIR". Convert to v4. ` <vs:FindVisualStudio /> The two elements are o...
github.com


________________________________
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> on behalf of Ron Martin via wix-devs <wix-devs at lists.wixtoolset.org>
Sent: Saturday, December 17, 2022 7:24 PM
To: wix-devs <wix-devs at lists.wixtoolset.org>
Cc: Ron Martin <cpuwzd at comcast.net>
Subject: [wix-devs] Merge Module Samples

@chrpai:

Chris, could you please supply one or more samples of module files that
do not convert to your liking?

The issue here seems to be quite different from the one I fixed. I'm
guessing that the the problem you are seeing stems from an attempt to
format a long attribute list. If that is the case, I'll need to come up
with a line folding heuristic. The formatting problem I worked on
previously involved converting inner text to comments and attribute
values, depending on where the deprecated inner text was found. There
were obvious places to remove and insert new-lines, and reasonable
places from which to copy indentations.

The parser places all of an element's attributes in a list, rather than
keeping them in XML nodes. I don't remember exactly where the attributes
are converted back to XML nodes, but that's probably where the fix will
have to go. Unfortunately, this has the potential to affect a lot of
other code paths that might require a lot of work to test
systematically. It will be really good to get this change into RC2, so
that it can get a fair shakedown.

Thanks,

Ron Martin
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/