[wix-devs] Core table and tuple definitions

[Rob Mensching]

1. There is not always a 1:1 mapping between Tuples and TableDefinitions. I suppose it's possible a TableDefinition could even exist without having a Tuple at all just like there are Tuples that don't create TableDefinitions. I'm not sure exactly what you are proposing here.

2. Probably bugs.

3. The cast is the same as doing the appropriate .AsXxx(). I suppose we should standardize on one or the other. Not sure I have huge preference.


-----Original Message-----
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of Bob Arnson via wix-devs
Sent: Saturday, April 11, 2020 4:27 PM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Cc: Bob Arnson <bob at firegiant.com>
Subject: Re: [wix-devs] Core table and tuple definitions

1. I suppose it should be possible to not have an associated tuple -- maybe a 1:n tuple:table relationship? But I definitely wouldn't optimize for it and if it makes it awkward, feel free to require it. 
2. Yeah, I'd assume it was incomplete translation.
3. (see #2)

-----Original Message-----
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of Sean Hall via wix-devs
Sent: Friday, 10 April, 2020 22:18
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Cc: Sean Hall <r.sean.hall at gmail.com>
Subject: [wix-devs] Core table and tuple definitions

I'm working on moving the table definitions out of Core's tables.xml and into Data with static definitions like I did for the extensions. I have a few questions:

1. Now that the tuple and table definitions will be defined in code, should the TableDefinition take the TupleDefinition instead of just the string for the name? If not, should there be a way to specify that a TableDefinition doesn't have a corresponding TupleDefinition?

2. There's a lot of inconsistency in the tuples around when to expose a nullable column as nullable. For instance, the IconIndex field for ClassTuple and the RunAsInteractiveUser field for AppIdTuple are nullable but the Ordering field for ContolEventTuple is not. Were some fields not exposed as nullable on purpose or are these just bugs?

3. Most of the tuples in Data are casting instead of using the AsBool, AsNumber, etc. extension methods. Should I make them using those instead of casting?
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/ ____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/