[wix-devs] WIXBUG4932 sent Pull Request to wix3, difficulty trying to do same for wix4
Heath.Stewart at microsoft.com
Mon Oct 26 09:28:24 PDT 2015
Did you stage your changes before you commit? Alternatively, you can use "git commit -a" to commit all staged and unstaged changes.
Visual Studio, Microsoft
From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On Behalf Of Phill Hogland
Sent: Sunday, October 25, 2015 1:24 PM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Subject: [wix-devs] WIXBUG4932 sent Pull Request to wix3, difficulty trying to do same for wix4
Yesterday I revived my wix3 dev sandbox, made the changes for WIXBUG 4932, committed and sent a PR. It all went so smooth that today I decided to try my hand at wix4. I created a wix4 fork, and then used Github desktop to create a local clone and then a branch for implementing the same changes as in 4932. The initial build of wix4 went fine (except that at the end of the build while creating the Summary Detail MSBuild through an exception indicating that multiple compares do not get the same result). I save the text of the error message, but since I have not seen it again after several builds, I am ignoring it.
So I made the changes for 4932, in the wix4 source, and checked them over, and then tried to commit them and then submit a pull request. The PR dialog says that there is nothing to commit so it won't enable sending the PR, admittedly I only noticed this after several confused tries, so maybe something was sent. Github desktop shows 11 changes. I am not sure if I caused a problem by using similar names or where the issue is.
Any advice is appreciated!
WiX Toolset Developer Mailing List provided by FireGiant https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fwww.firegiant.com%2f&data=01%7c01%7cHeath.Stewart%40microsoft.com%7cac1ad3216d8e4f008e2908d2dd7a45b8%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=F9GV6pwWa%2b5QLua6XGZS6K73b4U1p30AHX%2ftEFELweU%3d
More information about the wix-devs