[wix-devs] WIXBUG4932 sent Pull Request to wix3, difficulty trying to do same for wix4

[Phill Hogland]

OK thanks.  I was not sure what 'stage' meant but I read in Github help and found that on the display of the eleven changes there is a 'grayed' Commit to WIXBUG4932 button.  So I filled in that info and hit the button.  It worked.  Then I did the pull request and that failed.  I am a little concerned that the commit that I am trying to do to my fork of the wix4\develop tree is tromping on my fork of the wix3\develop tree maybe because I used the same WIXBUG4932 name.  But I wam really not sureof what I am doing with git (GitHub.  I just don't want to mess anything up on the wix git site.

-----Original Message-----
From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On Behalf Of Heath Stewart
Sent: Monday, October 26, 2015 11:28 AM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Subject: Re: [wix-devs] WIXBUG4932 sent Pull Request to wix3, difficulty trying to do same for wix4

Did you stage your changes before you commit? Alternatively, you can use "git commit -a" to commit all staged and unstaged changes.

Heath Stewart
Visual Studio, Microsoft
http://blogs.msdn.com/heaths

-----Original Message-----
From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On Behalf Of Phill Hogland
Sent: Sunday, October 25, 2015 1:24 PM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Subject: [wix-devs] WIXBUG4932 sent Pull Request to wix3, difficulty trying to do same for wix4

Yesterday I revived my wix3 dev sandbox, made the changes for WIXBUG 4932, committed and sent a PR.  It all went so smooth that today I decided to try my hand at wix4.  I created a wix4 fork, and then used Github desktop to create a local clone and then a branch for implementing the same changes as in 4932.  The initial build of wix4 went fine (except that at the end of the build while creating the Summary Detail MSBuild through an exception indicating that multiple compares do not get the same result).  I save the text of the error message, but since I have not seen it again after several builds, I am ignoring it.

So I made the changes for 4932, in the wix4 source, and checked them over, and then tried to commit them and then submit a pull request.  The PR dialog says that there is nothing to commit so it won't enable sending the PR, admittedly I only noticed this after several confused tries, so maybe something was sent.   Github desktop shows 11 changes.   I am not sure if I caused a problem by using similar names or where the issue is.

Any advice is appreciated!
Phill

____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fwww.firegiant.com%2f&data=01%7c01%7cHeath.Stewart%40microsoft.com%7cac1ad3216d8e4f008e2908d2dd7a45b8%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=F9GV6pwWa%2b5QLua6XGZS6K73b4U1p30AHX%2ftEFELweU%3d
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/