[wix-users] Burn Bootstrapper Repair Hangs on MSI Failure

Tue Apr 21 02:14:25 PDT 2020

FYI, I created https://github.com/wixtoolset/issues/issues/6158 from this.
Since I'm going to be changing how DisplayInternalUI works in v4, I needed
to know whether it and #4342 were bugs in the engine or the BA. I ended up
fixing them both, they were both in the BA. Although, the fixes won't go
into v3.14 unless someone convinces us to take the pull request.

On Fri, Apr 10, 2020 at 11:32 PM Tyler Gustafson <
Tyler.Gustafson at comtechtel.com> wrote:

> Ha! Thanks everyone.
> I tested this out with DisplayInternalUI="no" and got my expected result
> where the failure message was properly displayed no matter whether the
> bundle was installing fresh or repairing.
> I had a good reason for using DisplayInternalUI="yes" which escapes me at
> the moment, but I want to say it was because I used feature trees in one of
> my MSIs and there was a bug with EnableFeatureSelection="yes". I think it
> may have been this one https://github.com/wixtoolset/issues/issues/3689
> or one similar.
>
> I guess next steps are for my company to decide if we invest time in
> contributing to a fix, look for an acceptable workaround, or just live with
> this bug in the installers. For the record, I'm using WiX version
> 3.11.1.2318 so although issue #4094 looks like it was related, I believe
> this edge case still exists and should be considered an outstanding bug.
>
> Thanks again for your prompt replies,
> Tyler
>
>
> -----Original Message-----
> From: wix-users <wix-users-bounces at lists.wixtoolset.org> On Behalf Of
> Sean Hall via wix-users
> Sent: April 9, 2020 6:13 PM
> To: WiX Toolset Users Mailing List <wix-users at lists.wixtoolset.org>
> Cc: Sean Hall <r.sean.hall at gmail.com>
> Subject: Re: [wix-users] Burn Bootstrapper Repair Hangs on MSI Failure
>
>
> WARNING: External Email: Exercise Caution
>
> The keyword to search for would be DisplayInternalUI. This appears to be
> the same as
> https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fwixtoolset%2Fissues%2Fissues%2F4094&data=02%7C01%7CTyler.Gustafson%40comtechtel.com%7C8f67c29c82d04d89b1c408d7dcd32d7f%7Ca9a26e696ae040c1bd801ca6cc677828%7C0%7C0%7C637220671868448432&sdata=ADu%2FpzhLmlT3oFsFwQmBCHTGfFrmFhXndgC924NdQ6U%3D&reserved=0
> which was fixed in February 2017 so that should be in the latest v3.11.
> Hangs used to be a problem for DisplayInternalUI, but after the work of
> @aleksandr-grechko I would expect all of them to have been fixed.
>
> On Fri, Apr 10, 2020 at 6:00 AM Rob Mensching via wix-users <
> wix-users at lists.wixtoolset.org> wrote:
>
> > There was some discussion in WiX v4 about ways to re-implement Burn
> > and the BA's interaction with Windows Installer Internal UI.
> >
> > As it is, DisplayInternalUI has lots of "edge cases" (that aren't
> > terribly
> > edge) where it simply won't do the right thing. It was introduced
> > thinking it would be easy (famous last words).
> >
> > Jacob's disdain is not misplaced.
> >
> >
> > -----Original Message-----
> > From: wix-users <wix-users-bounces at lists.wixtoolset.org> On Behalf Of
> > Hoover, Jacob via wix-users
> > Sent: Thursday, April 9, 2020 11:50 AM
> > To: WiX Toolset Users Mailing List <wix-users at lists.wixtoolset.org>
> > Cc: Hoover, Jacob <Jacob.Hoover at greenheck.com>
> > Subject: Re: [wix-users] Burn Bootstrapper Repair Hangs on MSI Failure
> >
> > DisplayInternalUI="yes" is evil.
> >
> > When it fails the first time, and rolls back the failing MSI, but the
> > Bundle is in ARP/registered.
> >
> > When you run it a second time, it offers repair because of the ARP
> > registration.
> >
> > DisplayInternalUI="yes" sucks.  10 to 1 says if you let the bundle be
> > the proper UI, this wouldn't be an issue.
> >
> > If you can submit a test case, someone might have time to look into it
> > (or you could offer some time and join in on the wix-dev's meetings),
> > though I have 0 passion for DisplayInternalUI.
> >
> > Also, if you need this as a priority and don't have the time or
> > expertise to learn burn, there's also the option of paying
> >
> https://gcc02.safelinks.protection.outlook.com/?url=http%3A%2F%2Ffiregiant.com%2F&data=02%7C01%7CTyler.Gustafson%40comtechtel.com%7C8f67c29c82d04d89b1c408d7dcd32d7f%7Ca9a26e696ae040c1bd801ca6cc677828%7C0%7C0%7C637220671868448432&sdata=%2F08y%2BnWc1QrnqrYxa09gBgNBnrMuoqnvom16PrFXnVI%3D&reserved=0
> to do it.
> >
> > Did I mention that DisplayIntrernalU is an abomination and an insult
> > to the concept of a BA and a unified UX?
> >
> > From: wix-users [mailto:wix-users-bounces at lists.wixtoolset.org] On
> > Behalf Of Tyler Gustafson via wix-users
> > Sent: Thursday, April 9, 2020 1:34 PM
> > To: wix-users at lists.wixtoolset.org
> > Cc: Tyler Gustafson <Tyler.Gustafson at comtechtel.com>
> > Subject: [wix-users] Burn Bootstrapper Repair Hangs on MSI Failure
> >
> > Good morning,
> >
> > I've got a Burn Bootstrapper with a chain element that looks like this:
> > <Chain DisableRollback="yes">
> > <MsiPackage Id="WorkingMsi" SourceFile="Working.msi"
> > DisplayInternalUI="yes" Vital="yes" Visible="yes" /> <MsiPackage
> > Id="FailingMsi" SourceFile="Failing.msi" DisplayInternalUI="yes"
> > Vital="yes" Visible="yes" /> </Chain>
> >
> > I've designed Failing.msi with a CustomAction which will intentionally
> > fail the install:
> > <CustomAction Id="FailingAction" Directory="PRODUCTDIR"
> Execute="deferred"
> > Return="check" ExeCommand="[SystemFolder]cmd.exe /c "COLOR 00
> > > [PRODUCTDIR]FailingAction.log"" /> <InstallExecuteSequence>
> > <Custom Action="FailingAction" After="InstallFiles">(NOT Installed) OR
> > (Installed AND NOT REMOVE~="ALL")</Custom> </InstallExecuteSequence>
> >
> >
> >
> >
> > 1. The first time I run the bootstrapper, I see a window from the UI
> > of the Failing.msi at the appropriate point; "There is a problem with
> > this Windows Installer package. A program run as part of the setup did
> > not finish as expected. Contact your support personnel or package
> vendor."
> > After pushing ok, the bootstrapper shows an error message "One or more
> > issues caused the setup to fail. Please fix the issues and then retry
> > setup. For more information see the log file. 0x80070643 - Fatal error
> > during installation." Pushing Close exits gracefully. All of this is
> > expected behaviour.
> >
> >
> > 1. If I then try to run the bootstrapper again, I get a Repair option
> > (which I push) because the bootstrapper was intentionally not rolled
> > back and removed from system (DisableRollback="yes")
> >
> >
> > 1. This time, it does not show me the window indicating there is a
> > problem from step 1, but instead, hangs saying "Please wait while
> > Windows configures Failing". When I mouse over that window, it updates
> > the title bar from "Failing" to "Failing (Not Responding)". This is
> > not expected behaviour.
> >
> >
> > 1. I try to push the cancel button and get the standard windows dialog
> > asking if I want to close the program or wait for it to respond and I
> > choose to close the program.
> >
> >
> >
> > 1. Now I get the bootstrapper UI showing me the message that was
> > displayed by the msi's UI from step 1 "There is a problem with this
> > Windows Installer package. A program run as part of the setup did not
> finish as expected.
> > Contact your support personnel or package vendor." Pushing OK closes
> > the program as expected.
> >
> >
> > 1. Program flow starts from step 2 every time I run the bootstrapper
> > now, unless I uninstall it from add/remove programs. If I do that,
> > program flow starts over from step 1.
> >
> >
> > I think I'm seeing a bug with the interplay of bootstrapper repair,
> > and passing messages back from the msi. I can't find this listed as a
> > bug anywhere but I'll admit I'm not sure exactly what search terms to
> > use. Any insight would be appreciated.
> >
> > Thanks,
> > Tyler Gustafson
> > NOTICE TO RECIPIENT: This email, including attachments, may contain
> > information which is confidential, proprietary, attorney-client
> > privileged and / or controlled under U.S. export laws and regulations
> > and may be restricted from disclosure by applicable State and Federal
> > law. Nothing in this email shall create any legal binding agreement
> > between the parties unless expressly stated herein and provided by an
> > authorized representative of Comtech Telecommunications Corp. or its
> > subsidiaries. If you are not the intended recipient of this message,
> > be advised that any dissemination, distribution, or use of the
> > contents of this message is strictly prohibited. If you received this
> > message in error, please notify us immediately by return email and
> > permanently delete all copies of the original email and any attached
> > documentation from any computer or other media.
> >
> > ____________________________________________________________________
> > WiX Toolset Users Mailing List provided by FireGiant
> > https://gcc02.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.f
> > iregiant.com%2F&data=02%7C01%7CTyler.Gustafson%40comtechtel.com%7C
> > 8f67c29c82d04d89b1c408d7dcd32d7f%7Ca9a26e696ae040c1bd801ca6cc677828%7C
> > 0%7C0%7C637220671868448432&sdata=fhn%2FybZHAyS4Q1SR%2BSKVj0TeJVGgd
> > NjuvwDHlJTycjM%3D&reserved=0<https://gcc02.safelinks.protection.ou
> > tlook.com/?url=http%3A%2F%2Fwww.firegiant.com%2F&data=02%7C01%7CTy
> > ler.Gustafson%40comtechtel.com%7C8f67c29c82d04d89b1c408d7dcd32d7f%7Ca9
> > a26e696ae040c1bd801ca6cc677828%7C0%7C0%7C637220671868448432&sdata=
> > fhn%2FybZHAyS4Q1SR%2BSKVj0TeJVGgdNjuvwDHlJTycjM%3D&reserved=0>
> > NOTE: This email was received from an external source. Please use
> > caution when opening links or attachments in the message.
> >
> > ____________________________________________________________________
> > WiX Toolset Users Mailing List provided by FireGiant
> > https://gcc02.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.f
> > iregiant.com%2F&data=02%7C01%7CTyler.Gustafson%40comtechtel.com%7C
> > 8f67c29c82d04d89b1c408d7dcd32d7f%7Ca9a26e696ae040c1bd801ca6cc677828%7C
> > 0%7C0%7C637220671868448432&sdata=fhn%2FybZHAyS4Q1SR%2BSKVj0TeJVGgd
> > NjuvwDHlJTycjM%3D&reserved=0
> >
> > ____________________________________________________________________
> > WiX Toolset Users Mailing List provided by FireGiant
> > https://gcc02.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.f
> > iregiant.com%2F&data=02%7C01%7CTyler.Gustafson%40comtechtel.com%7C
> > 8f67c29c82d04d89b1c408d7dcd32d7f%7Ca9a26e696ae040c1bd801ca6cc677828%7C
> > 0%7C0%7C637220671868448432&sdata=fhn%2FybZHAyS4Q1SR%2BSKVj0TeJVGgd
> > NjuvwDHlJTycjM%3D&reserved=0
> >
>
> ____________________________________________________________________
> WiX Toolset Users Mailing List provided by FireGiant
> https://gcc02.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.firegiant.com%2F&data=02%7C01%7CTyler.Gustafson%40comtechtel.com%7C8f67c29c82d04d89b1c408d7dcd32d7f%7Ca9a26e696ae040c1bd801ca6cc677828%7C0%7C0%7C637220671868448432&sdata=fhn%2FybZHAyS4Q1SR%2BSKVj0TeJVGgdNjuvwDHlJTycjM%3D&reserved=0
> NOTICE TO RECIPIENT: This email, including attachments, may contain
> information which is confidential, proprietary, attorney-client privileged
> and / or controlled under U.S. export laws and regulations and may be
> restricted from disclosure by applicable State and Federal law. Nothing in
> this email shall create any legal binding agreement between the parties
> unless expressly stated herein and provided by an authorized representative
> of Comtech Telecommunications Corp. or its subsidiaries. If you are not the
> intended recipient of this message, be advised that any dissemination,
> distribution, or use of the contents of this message is strictly
> prohibited. If you received this message in error, please notify us
> immediately by return email and permanently delete all copies of the
> original email and any attached documentation from any computer or other
> media.
>