[wix-users] Insignia exit code of -1

[Isaac Devine]

Thanks everyone,

I've investigated the source code more deeply, and I've found that in
Inscriber#InscribeBundle it only marks it as inscribed if a container
is reattached:
https://github.com/wixtoolset/wix3/blob/bda1c281cb0349007d767d5404d6da87076d7d94/src/tools/wix/inscriber.cs#L152-L163

In particular I'm following the command lines as described in the help
document I linked to originally (
https://wixtoolset.org/documentation/manual/v3/overview/insignia.html
).
For completeness:
"C:\Program Files (x86)\WiX Toolset v3.11\bin\insignia.exe" -ib
"BundleOutput.exe" -o "engine.exe"

signtool sign /a /f PATH_TO_CERTIFICATE /tr
http://timestamp.digicert.com /fd sha256 /p PASSWORD engine.exe

"C:\Program Files (x86)\WiX Toolset v3.11\bin\insignia.exe" -ab
engine.exe "BundleOutput.exe" -o "ProgramSetup.exe" <-- this fails
with -1

signtool sign /a /f PATH_TO_CERTIFICATE /tr
http://timestamp.digicert.com /fd sha256 /p PASSWORD ProgramSetup.exe

Also adding the verbose flag (-v) doesn't change the output, or add any output.

Please note, that ProgramSetup is created, so insignia is actually
doing something; and that the ProgramSetup executable works.

Given my findings above (that inscribe only considers "work done" if a
container is re-attached), and
a) that my bundle has no embedded payloads (i.e. it downloads the
packages it needs to install), i.e. everything is marked as
compressed="no"
Does that mean:
b) I have no "attached containers" in my bundle?
c) Therefore, insignia doesn't mark it as inscribed, and returns -1?

Cheers,
Isaac

On Sat, Oct 26, 2019 at 7:05 AM Edwin Castro via wix-users
<wix-users at lists.wixtoolset.org> wrote:
>
> I'd recommend you check your command line args and make sure they're
> correct and what you expect. As Rob points out, you'll get that -1 when no
> work was done. There's generally two ways where no work is done. The first
> way is that command line args did not provide what to inscribe. The second
> way is that it was determined there was nothing to do. I didn't check the
> source too carefully but in my experience I never get -1 as a return code
> so I'd start with checking your command line args and go from there.
>
> --
> Edwin G. Castro
>
>
> On Fri, Oct 25, 2019 at 5:54 AM Rob Mensching via wix-users <
> wix-users at lists.wixtoolset.org> wrote:
>
> >
> > https://github.com/wixtoolset/wix3/blob/ec9f6c321b437634be21884b00a1b0b11d41c97d/src/tools/insignia/insignia.cs#L154-L156
> >
> > Short replies here. Complete answers over there: http://www.firegiant.com/
> >
> > -----Original Message-----
> > From: wix-users <wix-users-bounces at lists.wixtoolset.org> On Behalf Of
> > Isaac Devine via wix-users
> > Sent: Friday, October 25, 2019 12:23 AM
> > To: wix-users at lists.wixtoolset.org
> > Cc: Isaac Devine <isaac at smilesoftware.com>
> > Subject: [wix-users] Insignia exit code of -1
> >
> > Hi,
> >
> > I'm using insignia as described in
> > https://wixtoolset.org/documentation/manual/v3/overview/insignia.html
> >
> > And in particular, when I re-attach the burn engine (via the -ab
> > switch) insignia returns an exit code of -1.
> >
> > I can't find any documentation on this, apart from this source code
> > comment:
> >
> > https://github.com/wixtoolset/wix3/blame/bda1c281cb0349007d767d5404d6da87076d7d94/src/tools/insignia/insignia.cs#L154
> >
> > Is this something I should be concerned about? What does the comment mean
> > by nothing is inscribed?
> >
> > Cheers,
> > Isaac
> >
> > ____________________________________________________________________
> > WiX Toolset Users Mailing List provided by FireGiant
> > http://www.firegiant.com/
> >
> > ____________________________________________________________________
> > WiX Toolset Users Mailing List provided by FireGiant
> > http://www.firegiant.com/
> >
>
> ____________________________________________________________________
> WiX Toolset Users Mailing List provided by FireGiant http://www.firegiant.com/