[wix-users] Custom BA DisableModify

[Vanniekerk, Tyrel (GE Healthcare)]

Yes, I did not mean the burn app should add any functionality, my custom managed bootsrapper application will do that.  As Jacob said, it's just a matter of exposing the variable to the BootstrapperApplication so that the custom BA can hide the modify and repair options if they have been disabled.

-----Original Message-----
From: wix-users [mailto:wix-users-bounces at lists.wixtoolset.org] On Behalf Of Hoover, Jacob
Sent: Friday, September 30, 2016 12:17 PM
To: WiX Toolset Users Mailing List <wix-users at lists.wixtoolset.org>
Subject: EXT: Re: [wix-users] Custom BA DisableModify

I don't think the engine should do any special logic around this, but I do think we should expose these attributes in the manifest to the BA.

IE:
BalInfoParseFromXml

/BootstrapperApplicationData/WixBundleProperties/DisableModify


Looks like it could just be a tweak to the table definition, and add to Binder.cs, GenerateBAManifestBundleTables, if we think this is a good addition.

-----Original Message-----
From: wix-users [mailto:wix-users-bounces at lists.wixtoolset.org] On Behalf Of Rob Mensching
Sent: Friday, September 30, 2016 11:33 AM
To: WiX Toolset Users Mailing List <wix-users at lists.wixtoolset.org>
Subject: Re: [wix-users] Custom BA DisableModify

Phil is correct. What the use case for the Burn engine to do more work here?

PS: It's easy to say the engine should do everything but we do need to keep the engine maintainable. Failure in the engine isn't an option.
_____________________________________________________________
 Short replies here. Complete answers over there: https://urldefense.proofpoint.com/v2/url?u=http-3A__www.firegiant.com_&d=DQICAg&c=IV_clAzoPDE253xZdHuilRgztyh_RiV3wUrLrDQYWSI&r=oAJIeMTNC3Z6LlnozAjna4bWEZCGLInzcwB6EkZAFeU&m=SAHmFAHGs5u4MApAYK8VHScRNj5B_gMidSFAblR3gkg&s=zzn8hCqg57D7OBUCQAGQwMUFIaTxQ5hCVp13fen4d4E&e= 


-----Original Message-----
From: wix-users [mailto:wix-users-bounces at lists.wixtoolset.org] On Behalf Of Phill Hogland
Sent: Friday, September 30, 2016 8:48 AM
To: WiX Toolset Users Mailing List <wix-users at lists.wixtoolset.org>
Subject: Re: [wix-users] Custom BA DisableModify

OK, but again I think the disconnect is in your assumption that using Bundle/@DisableRepair or /@DisableModify results in anything being disabled in the Burn engine, which I don't think is correct so there would not be any properties for functionality which does not exist.

____________________________________________________________________
WiX Toolset Users Mailing List provided by FireGiant https://urldefense.proofpoint.com/v2/url?u=http-3A__www.firegiant.com_&d=DQICAg&c=IV_clAzoPDE253xZdHuilRgztyh_RiV3wUrLrDQYWSI&r=oAJIeMTNC3Z6LlnozAjna4bWEZCGLInzcwB6EkZAFeU&m=SAHmFAHGs5u4MApAYK8VHScRNj5B_gMidSFAblR3gkg&s=zzn8hCqg57D7OBUCQAGQwMUFIaTxQ5hCVp13fen4d4E&e= 

____________________________________________________________________
WiX Toolset Users Mailing List provided by FireGiant https://urldefense.proofpoint.com/v2/url?u=http-3A__www.firegiant.com_&d=DQICAg&c=IV_clAzoPDE253xZdHuilRgztyh_RiV3wUrLrDQYWSI&r=oAJIeMTNC3Z6LlnozAjna4bWEZCGLInzcwB6EkZAFeU&m=SAHmFAHGs5u4MApAYK8VHScRNj5B_gMidSFAblR3gkg&s=zzn8hCqg57D7OBUCQAGQwMUFIaTxQ5hCVp13fen4d4E&e=