[wix-users] Custom BA DisableModify

[Hoover, Jacob]

I don't think the engine should do any special logic around this, but I do think we should expose these attributes in the manifest to the BA.

IE:
BalInfoParseFromXml

/BootstrapperApplicationData/WixBundleProperties/DisableModify


Looks like it could just be a tweak to the table definition, and add to Binder.cs, GenerateBAManifestBundleTables, if we think this is a good addition.

-----Original Message-----
From: wix-users [mailto:wix-users-bounces at lists.wixtoolset.org] On Behalf Of Rob Mensching
Sent: Friday, September 30, 2016 11:33 AM
To: WiX Toolset Users Mailing List <wix-users at lists.wixtoolset.org>
Subject: Re: [wix-users] Custom BA DisableModify

Phil is correct. What the use case for the Burn engine to do more work here?

PS: It's easy to say the engine should do everything but we do need to keep the engine maintainable. Failure in the engine isn't an option.
_____________________________________________________________
 Short replies here. Complete answers over there: http://www.firegiant.com/


-----Original Message-----
From: wix-users [mailto:wix-users-bounces at lists.wixtoolset.org] On Behalf Of Phill Hogland
Sent: Friday, September 30, 2016 8:48 AM
To: WiX Toolset Users Mailing List <wix-users at lists.wixtoolset.org>
Subject: Re: [wix-users] Custom BA DisableModify

OK, but again I think the disconnect is in your assumption that using Bundle/@DisableRepair or /@DisableModify results in anything being disabled in the Burn engine, which I don't think is correct so there would not be any properties for functionality which does not exist.

____________________________________________________________________
WiX Toolset Users Mailing List provided by FireGiant http://www.firegiant.com/