[wix-users] Persisted hidden variables are written to log file

Thu Feb 11 09:08:08 PST 2016

Just to clarify, I suspect that when the WiX MsiProperty element is used, it creates a Public property (all uppercase), even though you specified a mixed cased name (a private Property) because Burn can only pass Public properties to an MSI.  You can validate this assumption by looking at the CommandLine passed in by Burn in the MSI's log.  If so you might argue that WiX should have flagged the mixed case MsiProperty/@Name as an error and file a WiX bug.   Someone can correct me if I am wrong on this assumption.  So in your case WiX created in Burn and passed on the command line to the MSI the uppercase Public Property (which was not marked as hidden) and your MSI package also had the mixed case hidden private property which you authored in the MSI package, a different MSI property which was hidden but not actually used.

-----Original Message-----
From: wix-users [mailto:wix-users-bounces at lists.wixtoolset.org] On Behalf Of Roni Fuchs
Sent: Thursday, February 11, 2016 10:37 AM
To: WiX Toolset Users Mailing List <wix-users at lists.wixtoolset.org>
Subject: Re: [wix-users] Persisted hidden variables are written to log file

You are all correct.
The problem was the mixed CamelCase and upper-case,
Where windows installer changed them to uppercase and they no longer were hidden.

Thanks everyone

-----Original Message-----
From: wix-users [mailto:wix-users-bounces at lists.wixtoolset.org] On Behalf Of Phill Hogland
Sent: Thursday, February 11, 2016 18:32
To: WiX Toolset Users Mailing List <wix-users at lists.wixtoolset.org>
Subject: Re: [wix-users] Persisted hidden variables are written to log file

I also checked my projects which is similar to the refactored code that I posted using uppercase for public MSI properties to be hidden, and the logs show that the values are hidden.

Since you mentioned custom actions, if you are trying to pass the hidden value to a CustomActionData for a deferred CA then you should look at CustomActrion/@HideTarget , or if you did not define the deferred CA (using a WiX CA), then you can define a 'hidden' Property that has the same name(same case) as the deferred CA.

-----Original Message-----
From: wix-users [mailto:wix-users-bounces at lists.wixtoolset.org] On Behalf Of Phill Hogland
Sent: Thursday, February 11, 2016 10:15 AM
To: WiX Toolset Users Mailing List <wix-users at lists.wixtoolset.org>
Subject: Re: [wix-users] Persisted hidden variables are written to log file

But I suspect that the mixed case property that you marked as 'hidden' is a different property than the uppercase property shown in you log which was not hidden.

-----Original Message-----
From: wix-users [mailto:wix-users-bounces at lists.wixtoolset.org] On Behalf Of Roni Fuchs
Sent: Thursday, February 11, 2016 10:00 AM
To: WiX Toolset Users Mailing List <wix-users at lists.wixtoolset.org>
Subject: Re: [wix-users] Persisted hidden variables are written to log file

Hi,

No it's not a typo, it works like this as well, inside the custom actions I check it as uppercase.

per

-----Original Message-----
From: wix-users [mailto:wix-users-bounces at lists.wixtoolset.org] On Behalf Of Phill Hogland
Sent: Thursday, February 11, 2016 17:41
To: WiX Toolset Users Mailing List <wix-users at lists.wixtoolset.org>
Subject: Re: [wix-users] Persisted hidden variables are written to log file

If this a typo?     MsiProperty/@Id="ManagementAccountPassword" /> 

I think it needs to be all uppercase to pass in as a MsiProperty public property, so I think your code should be:

Bundle code:
    <Variable
      Hidden="yes"
      Name="ManagementAccountPassword"
      Persisted="yes" />

      <MsiPackage

        Id="MsiPackage"

        SourceFile="$(var.Deployment.Package.TargetPath)">

        <MsiProperty

          Name="MANAGEMENTACCOUNTPASSWORD"

          Value="[ManagementAccountPassword]" />

      </MsiPackage>

Package code:

    <Property

      Hidden="yes"

      Id=" MANAGEMENTACCOUNTPASSWORD " />

-----Original Message-----
From: wix-users [mailto:wix-users-bounces at lists.wixtoolset.org] On Behalf Of Roni Fuchs
Sent: Thursday, February 11, 2016 9:21 AM
To: WiX Toolset Users Mailing List <wix-users at lists.wixtoolset.org>
Subject: [wix-users] Persisted hidden variables are written to log file

Hi everyone,

I'm passing hidden variables (password) from burn to the msi.
But they are still being written to the log file. How can I hide them completely?

Bundle code:
    <Variable
      Hidden="yes"
      Name="ManagementAccountPassword"
      Persisted="yes" />

      <MsiPackage

        Id="MsiPackage"

        SourceFile="$(var.Deployment.Package.TargetPath)">

        <MsiProperty

          Name="ManagementAccountPassword"

          Value="[ManagementAccountPassword]" />

      </MsiPackage>

Package code:

    <Property

      Hidden="yes"

      Id="ManagementAccountPassword" />

Log file hides it sometimes:
... ManagementAccountPassword=********** ...

But:
MSI (s) (64:80) [17:11:20:294]: PROPERTY CHANGE: Adding MANAGEMENTACCOUNTPASSWORD property. Its value is 'password'.
...
Property(S): MANAGEMENTACCOUNTPASSWORD = password

Thanks,

Roni (Aron) Fuchs

____________________________________________________________________
WiX Toolset Users Mailing List provided by FireGiant https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fwww.firegiant.com%2f&data=01%7c01%7cronif%40064d.mgd.microsoft.com%7c521bbb76e7644ec680ae08d332f9bd5f%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=hVzmts19HnxOHmmnrLc2Qt8lGx8cmd6Jee0akhs6FOw%3d

____________________________________________________________________
WiX Toolset Users Mailing List provided by FireGiant https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fwww.firegiant.com%2f&data=01%7c01%7cronif%40064d.mgd.microsoft.com%7c521bbb76e7644ec680ae08d332f9bd5f%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=hVzmts19HnxOHmmnrLc2Qt8lGx8cmd6Jee0akhs6FOw%3d

____________________________________________________________________
WiX Toolset Users Mailing List provided by FireGiant https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fwww.firegiant.com%2f&data=01%7c01%7cronif%40064d.mgd.microsoft.com%7c71aa660ac4c64013425708d33300ee3b%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=FY8tHozVKOPXKpbhX7Z0LDhKtESgC2%2f%2fqOESN%2btDxwM%3d

____________________________________________________________________
WiX Toolset Users Mailing List provided by FireGiant https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fwww.firegiant.com%2f&data=01%7c01%7cronif%40064d.mgd.microsoft.com%7c71aa660ac4c64013425708d33300ee3b%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=FY8tHozVKOPXKpbhX7Z0LDhKtESgC2%2f%2fqOESN%2btDxwM%3d

____________________________________________________________________
WiX Toolset Users Mailing List provided by FireGiant https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fwww.firegiant.com%2f&data=01%7c01%7cronif%40064d.mgd.microsoft.com%7c71aa660ac4c64013425708d33300ee3b%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=FY8tHozVKOPXKpbhX7Z0LDhKtESgC2%2f%2fqOESN%2btDxwM%3d

____________________________________________________________________
WiX Toolset Users Mailing List provided by FireGiant http://www.firegiant.com/