[wix-devs] Related Bundle Variables

[Hoover, Jacob]

Thanks.

Implemented the first 2 and pushed.

As for the 3rd, do we have an existing BAF test?  I am struggling a bit as to automating the test, and figured if we had an existing BAF test I could mirror or extend it's implementation.

From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of Sean Hall via wix-devs
Sent: Friday, November 4, 2022 3:40 PM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Cc: Sean Hall <r.sean.hall at gmail.com>
Subject: Re: [wix-devs] Related Bundle Variables

Here's a few things I noticed:

In ExternalEngineGetRelatedBundleVariable, I think it can just pass through
to BundleGetBundleVariableFixed. I don't see any benefit to creating a
local value.

The BAFunctions can use BalGetRelatedBundleVariable instead of
calling m_pEngine->GetRelatedBundleVariable directly so that it doesn't
have to worry about how big the string is.

The other BAFunctions test bundle is in that Manual folder because it is
for testing the UI functionality which can't easily be automated. It looks
like an automated test could be written for your BAFunctions bundle.

On Thu, Nov 3, 2022 at 2:43 PM Hoover, Jacob via wix-devs <
wix-devs at lists.wixtoolset.org<mailto:wix-devs at lists.wixtoolset.org>> wrote:

> I still have some cleanup to do but here's my progress:
> https://github.com/wixtoolset/wix4/compare/develop...jchoover:wix4:RelatedBundleVariable?expand=1<https://github.com/wixtoolset/wix4/compare/develop...jchoover:wix4:RelatedBundleVariable?expand=1>
>
> Any comments/feedback is appreciated.
>
> Thanks,
> Jacob
>
> ____________________________________________________________________
> WiX Toolset Developer Mailing List provided by FireGiant
> http://www.firegiant.com/<http://www.firegiant.com>
>
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/<http://www.firegiant.com/>
NOTE: This email was received from an external source. Please use caution when opening links or attachments in the message.