[wix-devs] Related Bundle Variables

[Sean Hall]

Here's a few things I noticed:

In ExternalEngineGetRelatedBundleVariable, I think it can just pass through
to BundleGetBundleVariableFixed. I don't see any benefit to creating a
local value.

The BAFunctions can use BalGetRelatedBundleVariable instead of
calling m_pEngine->GetRelatedBundleVariable directly so that it doesn't
have to worry about how big the string is.

The other BAFunctions test bundle is in that Manual folder because it is
for testing the UI functionality which can't easily be automated. It looks
like an automated test could be written for your BAFunctions bundle.

On Thu, Nov 3, 2022 at 2:43 PM Hoover, Jacob via wix-devs <
wix-devs at lists.wixtoolset.org> wrote:

> I still have some cleanup to do but here's my progress:
> https://github.com/wixtoolset/wix4/compare/develop...jchoover:wix4:RelatedBundleVariable?expand=1
>
> Any comments/feedback is appreciated.
>
> Thanks,
> Jacob
>
> ____________________________________________________________________
> WiX Toolset Developer Mailing List provided by FireGiant
> http://www.firegiant.com/
>