[wix-devs] Util.wixext.sln

Thu Jul 1 19:34:34 PDT 2021

  1.  src\test has a number of system tests that you’d normally run in a VM to avoid polluting your dev machine.
  2.  That’s the kind of change we’d typically mock (e.g., using RegUtil’s overrides) or just eyeball in a manual test. As above, we don’t have a good automation story for running tests that involve running real installs.

From: Ron Martin <cpuwzd at comcast.net>
Sent: Thursday, 1 July, 2021 13:57
To: Bob Arnson <bob at firegiant.com>; WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Subject: Re: [wix-devs] Util.wixext.sln

Bob,

Sorry for the slow response. I've been successfully using build.cmd to get my C++ changes compiled so that they
are included in .msi files that I build. I've been able to test and debug this code manually

I can't imagine an automated technology for testing these changes without using VM technology, an area in which my
experience is very weak. I say this because I don't think that creating user accounts on the test machine, with the
possibility that they are not removed by the testing process seems like an undesirable seems like a big
security risk.

How can I contribute the work I've done without taking a very long side trip to learn the ins and outs of this
technology? Are there any existing tests in Wix 4 that I can be use as models?

I've also found what appears to be an error in wcautil.h in the definitions of MessageExitOnLastErrorSource,
MessageExitOnFailureSource, and MessageExitOnNullWithLastErrorSource. Failing tests for artificial
instances of these macros seems reasonable, except that retrieving the results from an install log is
fairly awkward.

What's the best way to implement my fix. A straight-forward code review should suffice, but might not conform
to existing standards.

Thanks.

Ron

On 6/26/2021 5:14 PM, Bob Arnson wrote:
I’m not sure how to answer your questions. If you’re asking about adding a new C++ source file to a unit test project, that will require an addition to the .vcxproj. Unless you’re adding a new .vcxproj, no other changes should be necessary.

From: Ron Martin <cpuwzd at comcast.net><mailto:cpuwzd at comcast.net>
Sent: Tuesday, 15 June, 2021 21:49
To: Bob Arnson <bob at firegiant.com><mailto:bob at firegiant.com>; WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org><mailto:wix-devs at lists.wixtoolset.org>
Subject: Re: [wix-devs] Util.wixext.sln

Bob,

If I add a new C++ test file, will it get picked up automatically, or is there a .cmd file that I have to update to pick it
up? Since I can't debug this code in a debugger, I'm planning to use the log file as my eyes and ears. This does
make the length of the edit-build-test cycle more significant.

Is there anything more I need to know about building from the command line than to use VS 2019 command prompt (elevated?) and build.cmd (with or without the optional -release parameter? In order to log only the one test I care about, I assume that the log parameter has to go on the build command line constructed in the unit test itself.

I would never have intuited your advise. I'm just a little bit too far outside your communication loop and a little late
arriving. Perhaps there could be running list of meeting sessions in which such matters have been discussed (or I can just continue plucking feathers and other newbies can just read my messages in the wix-devs mailing list.

Thanks.

Ron
On 6/14/2021 10:45 PM, Bob Arnson wrote:

You can't build WiX projects inside Visual Studio yet. That includes WiX itself, for .wixlibs embedded in extensions. To build those, build WiX from the command line. If your test MSI is one produced as part of a unit test, the WiX build will build those and run the tests (again, from the command line).

-----Original Message-----

From: wix-devs <wix-devs-bounces at lists.wixtoolset.org><mailto:wix-devs-bounces at lists.wixtoolset.org> On Behalf Of Ron Martin via wix-devs

Sent: Monday, 14 June, 2021 19:57

To: wix-devs <wix-devs at lists.wixtoolset.org><mailto:wix-devs at lists.wixtoolset.org>

Cc: Ron Martin <cpuwzd at comcast.net><mailto:cpuwzd at comcast.net>

Subject: [wix-devs] Util.wixext.sln

Bob or Rob,

I don't know if this is what is holding me up, but I need to ask this again:

If you open the solution "Util.wixext.sln" in Debug mode in VS 2019, is the first project listed as "util (incompatible)"?

The conversion report seems to be telling me that Wix isn't installed.

util.wixproj references WixToolset.Sdk. There is a nuget package with that name, but I don't know how it's referenced.

Isn't it the "presence" of WixToolset.Sdk that allows VS 2019 to know what to do with .wixproj files?

How do I get the changes I make in src\ext\Util\ca\scauser.cpp to show up in my test msi?

Ron

____________________________________________________________________

WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/