[wix-devs] Burn unit tests

[Hoover, Jacob]

Was just trying to verify if it was something I did.  Changing the NULL's to L"" in 3 spots fixed my issue.

https://github.com/wixtoolset/burn/compare/master...jchoover:issue-3704?expand=1

I'm not done as I have cleanup and discussion to be had, but I was able to round trip via the registry persistence.

Specifically around https://github.com/wixtoolset/burn/compare/master...jchoover:issue-3704?expand=1#diff-8f2983bd6efe1ab3e72c589977bc1bd179dddb1562441a39890dee5cc89c7e8d

The new implementation uses the existing blob stream and persists it to/from the registry.  For per machine bundles this makes sense, since the unelevated engine is piping variables across to be persisted.  Still not sure if I like it, and slightly uncertain about the BURN_VARIANT_TYPE_NONE Handling.

From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of Rob Mensching via wix-devs
Sent: Thursday, April 29, 2021 11:01 AM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Cc: Rob Mensching <rob at firegiant.com>
Subject: Re: [wix-devs] Burn unit tests

This is good info. I think I'm seeing these asserts right now as I build the world in a debug build.

-----Original Message-----
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org<mailto:wix-devs-bounces at lists.wixtoolset.org>> On Behalf Of Sean Hall via wix-devs
Sent: Wednesday, April 28, 2021 12:52 PM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org<mailto:wix-devs at lists.wixtoolset.org>>
Cc: Sean Hall <r.sean.hall at gmail.com<mailto:r.sean.hall at gmail.com>>
Subject: Re: [wix-devs] Burn unit tests

Yes, they all pass on the CI server. The assertion doesn't fire there because it's always built with dutil in release mode. The tests don't actually look at those fields, so you could probably replace them with L"".

On Wed, Apr 28, 2021 at 2:41 PM Hoover, Jacob via wix-devs < wix-devs at lists.wixtoolset.org<mailto:wix-devs at lists.wixtoolset.org>> wrote:

> Are the current unit test expected to be functional?
>
> RelatedBundleMissingFromCacheTest
>
>
> DetectUpgradeBundle
>
> hr = PseudoBundleInitialize(0, &pRelatedBundle->package,
> TRUE, wzId, pRelatedBundle->relationType,
> BOOTSTRAPPER_PACKAGE_STATE_PRESENT,
> TRUE, NULL, NULL, NULL, 0, FALSE, L"-quiet", L"-repair -quiet",
> L"-uninstall -quiet", &dependencyProvider, NULL, 0);
> NativeAssert::Succeeded(hr, "Failed to initialize related
> bundle to represent bundle: %ls", wzId);
>
> (The 2 NULL's here: BOOTSTRAPPER_PACKAGE_STATE_PRESENT, TRUE, NULL,
> NULL)
>
>
> In Psuedo...
> hr = StrAllocString(&pPayload->sczFilePath, wzFilePath, 0);
> ExitOnFailure(hr, "Failed to copy filename for pseudo bundle.");
>
> hr = StrAllocString(&pPayload->sczSourcePath, wzLocalSource, 0);
> ExitOnFailure(hr, "Failed to copy local source path for pseudo
> bundle.");
>
> Calls
>
> AllocStringHelper
>
> static HRESULT AllocStringHelper(
> __deref_out_ecount_z(cchSource + 1) LPWSTR* ppwz,
> __in_z LPCWSTR wzSource,
> __in SIZE_T cchSource,
> __in BOOL fZeroOnRealloc
> )
> {
> Assert(ppwz && wzSource);
>
>
> Thanks,
> Jacob
>
> ____________________________________________________________________
> WiX Toolset Developer Mailing List provided by FireGiant
> http://www.firegiant.com/<http://www.firegiant.com>
>
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/<http://www.firegiant.com/>
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/<http://www.firegiant.com/>
NOTE: This email was received from an external source. Please use caution when opening links or attachments in the message.