[wix-devs] Burn unit tests

[Rob Mensching]

This is good info. I think I'm seeing these asserts right now as I build the world in a debug build. 

-----Original Message-----
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of Sean Hall via wix-devs
Sent: Wednesday, April 28, 2021 12:52 PM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Cc: Sean Hall <r.sean.hall at gmail.com>
Subject: Re: [wix-devs] Burn unit tests

Yes, they all pass on the CI server. The assertion doesn't fire there because it's always built with dutil in release mode. The tests don't actually look at those fields, so you could probably replace them with L"".

On Wed, Apr 28, 2021 at 2:41 PM Hoover, Jacob via wix-devs < wix-devs at lists.wixtoolset.org> wrote:

> Are the current unit test expected to be functional?
>
> RelatedBundleMissingFromCacheTest
>
>
> DetectUpgradeBundle
>
>             hr = PseudoBundleInitialize(0, &pRelatedBundle->package, 
> TRUE, wzId, pRelatedBundle->relationType, 
> BOOTSTRAPPER_PACKAGE_STATE_PRESENT,
> TRUE, NULL, NULL, NULL, 0, FALSE, L"-quiet", L"-repair -quiet", 
> L"-uninstall -quiet", &dependencyProvider, NULL, 0);
>             NativeAssert::Succeeded(hr, "Failed to initialize related 
> bundle to represent bundle: %ls", wzId);
>
> (The 2 NULL's here: BOOTSTRAPPER_PACKAGE_STATE_PRESENT, TRUE, NULL, 
> NULL)
>
>
> In Psuedo...
>     hr = StrAllocString(&pPayload->sczFilePath, wzFilePath, 0);
>     ExitOnFailure(hr, "Failed to copy filename for pseudo bundle.");
>
>     hr = StrAllocString(&pPayload->sczSourcePath, wzLocalSource, 0);
>     ExitOnFailure(hr, "Failed to copy local source path for pseudo 
> bundle.");
>
> Calls
>
> AllocStringHelper
>
> static HRESULT AllocStringHelper(
>     __deref_out_ecount_z(cchSource + 1) LPWSTR* ppwz,
>     __in_z LPCWSTR wzSource,
>     __in SIZE_T cchSource,
>     __in BOOL fZeroOnRealloc
>     )
> {
>     Assert(ppwz && wzSource);
>
>
> Thanks,
> Jacob
>
> ____________________________________________________________________
> WiX Toolset Developer Mailing List provided by FireGiant 
> http://www.firegiant.com/
>
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/