[wix-devs] 4099 - Support outbound firewall rule

[Bob Arnson]

Then mission accomplished?

-----Original Message-----
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of Sean Hall via wix-devs
Sent: Thursday, 21 May, 2020 19:10
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Cc: Sean Hall <r.sean.hall at gmail.com>
Subject: Re: [wix-devs] 4099 - Support outbound firewall rule

There's already a pull request in v4 implementing it through a new column that I could take.

On Fri, May 22, 2020 at 9:07 AM Bob Arnson <bob at firegiant.com> wrote:

> I think v4 should have a better design, not relying on a bit to 
> indicate outbound exceptions. So that turns it into a question: Would 
> we take this in v3.14 even without an equivalent in v4?
>
> -----Original Message-----
> From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of 
> Sean Hall via wix-devs
> Sent: Tuesday, 19 May, 2020 21:28
> To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
> Cc: Sean Hall <r.sean.hall at gmail.com>
> Subject: Re: [wix-devs] 4099 - Support outbound firewall rule
>
> So we should leave a comment on
> https://github.com/wixtoolset/wix3/pull/513
> saying we'll take it if they fix the feaOutbound value and also submit 
> it to v4?
>
> On Wed, May 20, 2020 at 11:08 AM Bob Arnson <bob at firegiant.com> wrote:
>
> > Overloading an existing column is the only way to do it for v3.14.
> > That said, it's more like abusing the attributes column -- outbound 
> > isn't a flag, it's direction with two possible values. And the 
> > feaOutbound value is wrong.
> >
> > That said, the change itself seems otherwise safe for v3.14.
> >
> > -----Original Message-----
> > From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of 
> > Sean Hall via wix-devs
> > Sent: Tuesday, 19 May, 2020 20:22
> > To: WiX Toolset Developer Mailing List 
> > <wix-devs at lists.wixtoolset.org>
> > Cc: Sean Hall <r.sean.hall at gmail.com>
> > Subject: [wix-devs] 4099 - Support outbound firewall rule
> >
> > We have some pull requests for this feature. One implements it by 
> > adding a new column, and another does it through the existing 
> > attribute column. Does anyone have any opinions about which way it 
> > should be done? If we go with the attribute column, would we take it 
> > in
> v3.14?
> >
> > https://github.com/wixtoolset/issues/issues/4009
> > ____________________________________________________________________
> > WiX Toolset Developer Mailing List provided by FireGiant 
> > http://www.firegiant.com/
> >
> ____________________________________________________________________
> WiX Toolset Developer Mailing List provided by FireGiant 
> http://www.firegiant.com/
>
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/