[wix-devs] 5355 - util:RegistrySearch clears the variable when the key or value is not found
bob at firegiant.com
Fri Jun 26 16:53:16 PDT 2020
Probably they wouldn't, but they might have which would be a behavior change that might be breaking. It's a general problem: When we make breaking changes, should we add warnings to wix-convert? It seems like the best place.
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of Sean Hall via wix-devs
Sent: Friday, 26 June, 2020 18:42
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Cc: Sean Hall <r.sean.hall at gmail.com>
Subject: Re: [wix-devs] 5355 - util:RegistrySearch clears the variable when the key or value is not found
Do we need a warning? I have a hard time coming up with a scenario where someone would actually want the current behavior. If they were only interested in the value from the search, then they wouldn't have set a default value in the variable. If they actually wanted the proposed behavior, then they would have a workaround that should still work with the behavior change.
On Sat, Jun 27, 2020 at 4:22 AM Bob Arnson <bob at firegiant.com> wrote:
> I also think it's an excellent proposal. I'm not sure to do in WixCop,
> other than issue a warning. The typical workaround in v3 was to author
> an "Exists" key for every other, so you could say "FooExists and
> FooVersion = v1.0" -- that would still work in most cases but could be simplified.
> -----Original Message-----
> From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of
> Sean Hall via wix-devs
> Sent: Thursday, 25 June, 2020 22:26
> To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
> Cc: Sean Hall <r.sean.hall at gmail.com>
> Subject: [wix-devs] 5355 - util:RegistrySearch clears the variable
> when the key or value is not found
> I'd like to get https://github.com/wixtoolset/issues/issues/5355
> designed since the proposal is technically a breaking change: "Rather
> than add a Default attribute, maybe the search should work like MSI,
> where a missing value doesn't overwrite the default." I think the
> proposal is good, unless someone else wants to do it differently?
> WiX Toolset Developer Mailing List provided by FireGiant
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/
More information about the wix-devs