[wix-devs] 3816 - Add variable and absolute path functionality to Bundle/Log element

[Sean Hall]

I would be surprised if anyone is actually depending on the fact that it's
not getting formatted so I'm not trying to avoid making a breaking change
here. I think we should always format the Prefix, and then if it's an
absolute path then do the right thing to get the log in that absolute path.
If they want to use literal []'s then they need to escape them. Since
Prefix can only be set in authoring, it's the author's choice whether to
include a secure Variable in there.

On Fri, Jun 26, 2020 at 11:18 PM Hoover, Jacob <Jacob.Hoover at greenheck.com>
wrote:

> Could introduce a  Log/@PrefixFormatted YesNoType with a default of no, if
> we really wanted to avoid breaking things.  The problem becomes
> differentiating between path’s with []’s and an actual variable. Would the
> intent be to parse the value, looking for possible variables, and only
> resolve them if the variables exist, otherwise leave them as is?  What
> about secure vars?
>
>
>
> *From:* wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] *On
> Behalf Of *Sean Hall via wix-devs
> *Sent:* Thursday, June 25, 2020 9:17 PM
> *To:* WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
> *Cc:* Sean Hall <r.sean.hall at gmail.com>
> *Subject:* [wix-devs] 3816 - Add variable and absolute path functionality
> to Bundle/Log element
>
>
>
> I feel like implementing https://github.com/wixtoolset/issues/issues/3816
> would
> technically be a breaking change. People could have been relying on the
> Prefix not being formatted. Unless we don't want to use the Prefix
> attribute for this?
> ____________________________________________________________________
> WiX Toolset Developer Mailing List provided by FireGiant
> http://www.firegiant.com/
>
> NOTE: This email was received from an external source. Please use caution
> when opening links or attachments in the message.
>