[wix-devs] BundleCustomData and WixCop

[Bob Arnson]

> CustomTableRef

+1. It's been on my list...

> Add a warning for all CustomTable elements?

Reasonable.

-----Original Message-----
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of Sean Hall via wix-devs
Sent: Sunday, 21 June, 2020 20:28
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Cc: Sean Hall <r.sean.hall at gmail.com>
Subject: Re: [wix-devs] BundleCustomData and WixCop

It works just like CustomTable with different names.
BundleCustomData=CustomTable
BundleAttributeDefinition=Column
BundleElement=Row
BundleAttribute=Data

Well, it did. I'm going to add BundleCustomDataRef that you have to use for the case where you're just adding Rows (BundleElements). This is because the Type attribute is required for BundleCustomData and should only be specified when you're defining the schema. I can add CustomTableRef to do the same thing for CustomTables if we want to do that.

Right now we're converting CustomTable by turning BootstrapperApplicationData into Unreal. Should I remove that code? Add a warning for all CustomTable elements?

On Mon, Jun 22, 2020 at 4:32 AM Rob Mensching <rob at firegiant.com> wrote:

> Yeah, any elements that require linking are probably out of scope for 
> conversion. I haven't seen enough examples of the new 
> BootstrapperApplicationData usage to have any better ideas.
>
> -----Original Message-----
> From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of 
> Sean Hall via wix-devs
> Sent: Saturday, June 20, 2020 10:22 PM
> To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
> Cc: Sean Hall <r.sean.hall at gmail.com>
> Subject: Re: [wix-devs] BundleCustomData and WixCop
>
> I have another problem, there's no way for WixCop ("wix convert"?) to 
> know whether a CustomTable element was for BootstrapperApplicationData 
> unless it's the element that defined the table.
>
> On Sat, Jun 20, 2020 at 2:54 AM Rob Mensching <rob at firegiant.com> wrote:
>
> > v3 BootstrapperApplicationData should be migrated to the new way of 
> > defining "bundle data" in v4.
> >
> > Unreal can be treated as a new concept with no conversion path from v3.
> >
> >
> > -----Original Message-----
> > From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of 
> > Sean Hall via wix-devs
> > Sent: Friday, June 19, 2020 4:36 AM
> > To: WiX Toolset Developer Mailing List 
> > <wix-devs at lists.wixtoolset.org>
> > Cc: Sean Hall <r.sean.hall at gmail.com>
> > Subject: [wix-devs] BundleCustomData and WixCop
> >
> > I updated the WIP to match the change from Burn to Bundle, added the 
> > ExtensionId attribute for Type=BundleExtension, and removed the 
> > removal of CustomTable/@Unreal.
> >
> > Since we're not getting rid of CustomTable/@Unreal, the migration of 
> > v3's CustomTable/@BootstrapperApplicationData is now ambiguous. What 
> > is WixCop supposed to do?
> > ____________________________________________________________________
> > WiX Toolset Developer Mailing List provided by FireGiant 
> > http://www.firegiant.com/
> >
> ____________________________________________________________________
> WiX Toolset Developer Mailing List provided by FireGiant 
> http://www.firegiant.com/
>
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/