[wix-devs] 6210 - Burn engine should handle non-QWORD versions

[Rob Mensching]

Looking closer at the PR, the more it seems that what we have discussed and Sean has coded, is a very good marriage of "4-part versions" with "SemVer".

Is there any reason we shouldn't promote this versioning to "verutil.h" in dutil and make it the standard handling of versions going forward?

-----Original Message-----
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of Rob Mensching via wix-devs
Sent: Tuesday, July 14, 2020 12:36 PM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Cc: Rob Mensching <rob at firegiant.com>
Subject: Re: [wix-devs] 6210 - Burn engine should handle non-QWORD versions

Correct me if I'm wrong but using EvaluateCondition() would require all version comparisons to be created using string concatenation in the BA then call to evaluate condition? That's pretty ugly.

Dutil isn't easily discoverable but there is precedent as wcautil depends on it. Balutil could do similarly.

I guess I'm not against sending versions around as strings but I think we do need to make some methods available for doing standard version comparisons (anything else) on those strings.

Is the breaking changes concern related to shipping around a struct? If so, I get that (thus string fallback is better than an opaque handle because at least someone can display a string). But the actual version comparisons, we'll have to get right because changing those will be breaking change whether a string or struct or whatever.


-----Original Message-----
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of Sean Hall via wix-devs
Sent: Monday, July 13, 2020 3:08 AM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Cc: Sean Hall <r.sean.hall at gmail.com>
Subject: Re: [wix-devs] 6210 - Burn engine should handle non-QWORD versions

I updated the WIP based on what we discussed in last week's meeting. I've got the implementation of parsing and comparing the versions in butil in https://github.com/wixtoolset/dutil/pull/16.

I don't really want to expose an API from Burn to parse a version. Hiding the implementation details allows us to make breaking changes. Also, there's no relationship between Burn's headers and dutil's headers so it would be tricky to do.

Burn already exposes an API to compare versions - EvaluateCondition. So I think the only Burn API changes will be changing QWORD to LPWSTR.

On Wed, Jul 8, 2020 at 10:59 PM Sean Hall <r.sean.hall at gmail.com> wrote:

> I went ahead and created a separate issue for Burn supporting 
> non-QWORD versions, and 4666 can be about authoring them. I created a 
> WIP for this at https://wixtoolset.org/development/wips/6210-burn-engine-semantic-versioning/.
> I would like feedback on this.
>
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/ ____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/