[wix-devs] WixComPlusExtension Status update 1

[Blair Murri]

I'd go with the separate element, since it appears to be a different operation.

Get Outlook for Android<https://aka.ms/ghei36>

________________________________
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> on behalf of Allen, Eric M. (Tax&Accounting Prof) via wix-devs <wix-devs at lists.wixtoolset.org>
Sent: Friday, August 16, 2019 9:58:04 AM
To: Edwin Castro <egcastr at gmail.com>; WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Cc: Allen, Eric M. (Tax&Accounting Prof) <eric.allen at thomsonreuters.com>
Subject: Re: [wix-devs] WixComPlusExtension Status update 1

As I noted before, we would wind up with one element name (ComPlusAssembly) which has two almost completely different schema to be used depending on whether Import=Yes or No.

If I were to reuse an existing element, it probably makes more sense to use ComPlusComponent as a child of the Application. At that point we could decide whether to use an Import=Yes|No attribute as a sanity check (error if Import=yes and child of Assembly; error if Import=no and child of Application).

Before going down that path, I would feel compelled to determine which other attributes of ComPlusComponent would need to be ignored or forbidden when it is a child of the Application.

I'm not saying this is absolutely impossible, but it's quite a bit more time-to-completion.

From: Edwin Castro <egcastr at gmail.com>
Sent: Friday, August 16, 2019 12:57 AM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Cc: Rob Mensching <rob at firegiant.com>; Allen, Eric M. (Tax&Accounting Prof) <eric.allen at thomsonreuters.com>
Subject: Re: [wix-devs] WixComPlusExtension Status update 1

That explains why it sounds weird. As an adjective, Imported should be at the beginning: ImportedComPlusComponent

<comPlus:ImportedComPlusComponent Id="CalculatorComPlusComponent CLSID="D0213ABD-5928-481E-AF3E-51B860AF47D2"/>

What if instead of replacing <comPlus:ComPlusAssembly/> with <comPlus:ComPlusImportedComponent/> (or <comPlus:ImportedComPlusComponent/>) perhaps you add an Import="yes|no" attribute (defaulted to "no") to <comPlus:ComPlusAssembly/> and conditionalize behavior based on the Import attribute?

--
Edwin G. Castro
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/