[wix-devs] Building Votive

[Christopher Painter]

Mystery solved. I was missing VS 2010 SDK SP1.  It seems this doesn't cause a build break it just causes an undesirable outcome (.vsix missing .dll ).


Now to submit the pull request.  If anyone needs this before  the WiX team  accepts the PR  I' can have it posted as a release on in my repos.


Next thing I need to look at is the VSExtension.   I need it updated to support VS2019  as this is how IsWiX registers itself with VS.

________________________________
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> on behalf of Christopher Painter via wix-devs <wix-devs at lists.wixtoolset.org>
Sent: Sunday, December 16, 2018 1:57 PM
To: WiX Toolset Developer Mailing List
Cc: Christopher Painter
Subject: Re: [wix-devs] Building Votive

Ya, as best I can tell the .sln takes the place of the wix.proj.    There's building-wix page makes mention of updating an assemblyinfo.cs in a path that doesn't seem to exist yet.    I'm building both similiar and passing the OFFICIAL_WIX_BUILD  property and it seems to build correctly with the exception that votive.dll doesn't get included in the vsix.  I have to copy it manually and then it seems to accept it.

________________________________
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> on behalf of Sean Hall via wix-devs <wix-devs at lists.wixtoolset.org>
Sent: Sunday, December 16, 2018 12:26 PM
To: WiX Toolset Developer Mailing List
Cc: Sean Hall
Subject: Re: [wix-devs] Building Votive

I glanced through the repo. It looks like Rob set it up much like the v3
repo. It has a one-time initialization project, the same strong key signing
parameters, and a single thing to build in the root of the repo. The only
additional prerequisite seems to be you need to install the VS 2010 SP1
SDK. I'm pretty sure there was a link to it in the Building Wix page.

On Sun, Dec 16, 2018 at 8:07 AM Christopher Painter via wix-devs <
wix-devs at lists.wixtoolset.org> wrote:

> I'm trying to work in issue 5915 (vs2019-votive)  and I want to make sure
> that I can build/test my new 2019 AddIn on a clean machine using the
> official-unofficial build pattern before submitting a pull request.
>
>
> The closest I can get currently is the VSIX is generated but it's missing
> votive.dll.  If I copy votive.dll to the extracted extensions location of
> VS  then it all works.    This is happening before I touch any of the code
> so I'm suspecting it's a gap in my build process.
>
>
> Does this ring a bell with anyone?
>
>
> Thanks,
>
> Chris
> ____________________________________________________________________
> WiX Toolset Developer Mailing List provided by FireGiant
> http://www.firegiant.com/
WiX Support | WiX Experts and Resources from FireGiant<http://www.firegiant.com/>
www.firegiant.com<http://www.firegiant.com>
WiX Support | Installation, Development, Deployment | WiX Experts and Resources from FireGiant



>
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/