[wix-devs] Topic for todays discussion, WIXBUG:4899

[Rob Mensching]

It's been like that for probably a decade. E_FAIL was eradicated from the WiX toolset code base at one time. There was also a phase where S_FALSE was believe to be a reasonable thing to return. That belief has also been fixed, but some old code was not changed because "break".

_______________________________________________________________
 FireGiant  |  Dedicated support for the WiX toolset  |  http://www.firegiant.com/

-----Original Message-----
From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On Behalf Of Hoover, Jacob
Sent: Tuesday, September 22, 2015 8:54 AM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Subject: [wix-devs] Topic for todays discussion, WIXBUG:4899

I've commented on this bug a bit, and would like to have a discussion on it in today's meeting. I've tried to go back in time to see when this behavior was last changed, but I can't seem to find a way to go back farther than git on Codeplex.  If anyone has a HG mirror of the old Wix code, it would be interesting to see who commented out the line "// hr = E_FAIL;" inside of xmlutil.cpp in the XmlGetAttribute function.

Thanks,
Jacob

____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/