[wix-users] GitHub actions: Wix.targets no longer found

[Daniel Lidström]

I meant to point to a comment on the issue. I now see that the suggested lines in that comment are already included in the template you linked to. Specifically, MSBuildExtensionsPath32 was a new variable in my script.
I didn’t look closely enough at the template you suggested, sorry for the noise.

/Daniel
On 27 Nov 2021, 04:13 +0100, Rob Mensching <rob at firegiant.com>, wrote:
> That issue you linked to points at updating the .wixproj as I suggested in option 1 below. Did you mean to point at something else?
>
> -----Original Message-----
> From: wix-users <wix-users-bounces at lists.wixtoolset.org> On Behalf Of Daniel Lidström via wix-users
> Sent: Friday, November 26, 2021 1:23 PM
> To: WiX Toolset Users Mailing List <wix-users at lists.wixtoolset.org>
> Cc: Daniel Lidström <dlidstrom at gmail.com>
> Subject: Re: [wix-users] GitHub actions: Wix.targets no longer found
>
> Hi Rob
>
> I found the issue. It seems with the release of 64-bit visual studio that msbuild extensions have been separated into different folders, depending on architecture.
>
> https://github.com/actions/virtual-environments/issues/4419#issuecomment-978916739
>
> /Daniel
> On 26 Nov 2021, 17:42 +0100, Rob Mensching <rob at firegiant.com>, wrote:
> > Two things:
> >
> > 1. Make sure your .wixproj is up to date. There was a breaking change in MSBuild a long time ago that forced a change to how Imports worked. Make sure yours looks like the new template: https://github.com/wixtoolset/VisualStudioExtension/blob/develop/src/Templates/v3/Projects/WixProject/SetupProject.wixproj
> >
> > 2. GitHub Actions and Azure Pipelines decided to "simplify" their images and removed a lot of software. Bob did the work to get WiX added back to the image (I can't find the commit right now). It's possible that change to add WiX back isn't rolled out yet.
> >
> > If the latter, please do feel free to complain at GitHub Actions/Azure Pipelines about breaking you. They've created a spike in support burden for us unnecessarily, it would be good for them to realize it.
> >
> >
> > -----Original Message-----
> > From: wix-users <wix-users-bounces at lists.wixtoolset.org> On Behalf Of Daniel Lidström via wix-users
> > Sent: Friday, November 26, 2021 6:44 AM
> > To: WiX Toolset Users Mailing List <wix-users at lists.wixtoolset.org>
> > Cc: Daniel Lidström <dlidstrom at gmail.com>
> > Subject: [wix-users] GitHub actions: Wix.targets no longer found
> >
> > I had a setup where I could use Wix through msbuild, something which requires importing Wix.targets. However it has stopped working. I am using windows-2019 runner and I’m seeing this error:
> > error MSB4019: The imported project "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\WiX\v3.x\Wix.targets" was not found. Confirm that the expression in the Import declaration "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\WiX\v3.x\Wix.targets" is correct, and that the file exists on disk.
> > The relevant part of my msbuild script is this:
> > <PropertyGroup><WixTargetsPath Condition=" '$(WixTargetsPath)' == '' ">$(MSBuildExtensionsPath)\Microsoft\WiX\v3.x\Wix.targets</WixTargetsPath>
> > …
> > Does anyone know where the file has gone? I’ve asked in the GitHub community forums as well, but thought I’d ask the experts here if there’s anything I’m doing wrong.
> > Thanks!
> >
> > /Daniel
> >
> > ____________________________________________________________________
> > WiX Toolset Users Mailing List provided by FireGiant http://www.firegiant.com/
>
> ____________________________________________________________________
> WiX Toolset Users Mailing List provided by FireGiant http://www.firegiant.com/