[wix-users] property not updated during maintenance

[Rob Mensching]

Would I personally look? No, probably not. Maybe someone else here would be interested. 

Just keep in mind: https://robmensching.com/support


---
Short replies here. Complete answers here: https://www.firegiant.com/services/

-----Original Message-----
From: wix-users <wix-users-bounces at lists.wixtoolset.org> On Behalf Of Hagen Kant via wix-users
Sent: Wednesday, February 3, 2021 1:52 PM
To: WiX Toolset Users Mailing List <wix-users at lists.wixtoolset.org>
Cc: Hagen Kant <hagen.kant at gmail.com>
Subject: Re: [wix-users] property not updated during maintenance

Hi,

if there is nothing obvious which has to be taken care of differently between "install" and "modify" to change and promote a property to the custom .dll action, then I suspect a bug in the related software. To be able to demonstrate this I could create a dummy installer and custom .dll and provide the source code (i.e. at github). Would you consider looking at it?

Viele Grüße/Cheers,
Hagen.

> On 29.01.2021, at 18:28, Hagen Kant <hagen.kant at gmail.com> wrote:
> 
> Thanks, Rob,
> 
> for the very quick response!
> But, no, the problem is not that the property is not remember across different runs of the installer. Its that during maintenance ("modify") the property that should have been updated by presenting the user again with the custom dialog does not get updated. The value the user selects is ignored and instead the default value gets promoted to the custom .dll action.
> 
> Thanks!
> Viele Grüße/Cheers,
> Hagen.
> 
>> On 29.01.2021, at 17:56, Rob Mensching <rob at firegiant.com> wrote:
>> 
>> I think you want this: https://robmensching.com/blog/posts/2010/5/2/the-wix-toolsets-remember-property-pattern
>> 
>> 
>> Short replies here. Complete answers here: https://www.firegiant.com/services/
>> 
>> -----Original Message-----
>> From: wix-users <wix-users-bounces at lists.wixtoolset.org> On Behalf Of Hagen Kant via wix-users
>> Sent: Friday, January 29, 2021 8:51 AM
>> To: wix-users at lists.wixtoolset.org
>> Cc: Hagen Kant <hagen.kant at gmail.com>
>> Subject: [wix-users] property not updated during maintenance
>> 
>> Hi,
>> 
>> first of all, thanks for the great tool set! 
>> While the wix toolset xml format itself is quite well documented, its a bit strange that - given the complexity of the concept - it lacks a comprehensive conceptual documentation, including lists of valid attributes values, when and how to schedule actions, etc., which probably causes the following question:
>> 
>> My WixUI_FeatureTree based installer has a custom dialog mounted between CustomizeDlg and VerifyReadyDlg which sets a property via ComboBox/ComboList. 
>> 
>> 			<Control Id="Instances" Type="ComboBox" X="45" Y="135" Width="40" Height="18" Integer="yes" ComboList="yes" Sorted="yes" Property="INSTANCES">
>> 				<ComboBox Property="INSTANCES">
>> 					<ListItem Value="2"/>
>> 					[...]
>> 					<ListItem Value="12"/>
>> 				</ComboBox>
>> 			</Control>
>> 
>> The value is used in a deferred (elevated) custom .dll action:
>> 
>> 			<CustomAction Id="UpdateInstances.SetProperty" Property="UpdateInstances" Value="[INSTANCES]"/>
>> 			<CustomAction Id="UpdateInstances" Execute="deferred" Impersonate="no" BinaryKey="$(var.dll)" DllEntry="UpdateInstances"/>
>> 
>> scheduled via InstallExecuteSequence:
>> 
>> 			<Custom Action="UpdateInstances.SetProperty" Before="UpdateInstances">NOT REMOVE</Custom>
>> 			<Custom Action="UpdateInstances" Before="InstallFinalize">NOT REMOVE</Custom>
>> 	
>> This works well for the install case, but for the maintenance ("modify") action it does not update the property. (it keeps its default.)
>> 
>> 	<Property Id="INSTANCES" Value="2"/>
>> 
>> Any hint what could cause such a behaviour, or idea what to try is highly appreciated.
>> 
>> Thanks and best regards,
>> Hagen.
>> 
>> 
>> ____________________________________________________________________
>> WiX Toolset Users Mailing List provided by FireGiant http://www.firegiant.com/
> 


____________________________________________________________________
WiX Toolset Users Mailing List provided by FireGiant http://www.firegiant.com/