[wix-users] Handling InvalidDataException in DetectComplete when parsing malformed BALConditions

[Jacques Eloff]

Since it failed on the first condition, my internal list was completely
invalid and the NPE slipped through.

On Wed, May 15, 2019 at 9:09 AM Jacques Eloff <repstosd at gmail.com> wrote:

> Hi
>
> I've got a custom bootstrapper and processing BalCondition entries during
> DetectComplete.
>
> I noticed when there's a syntax error, I'm getting an
> InvalidDataException. I'm able to log the exception (Engine.Evaluate is
> inside a try/catch), but it appears that the engine terminates and I can't
> surface the exception in the UI (my UI is only launched after
> DetectComplete).
>
> [2484:695C][2019-05-14T22:57:04]e051: Error 0. Failed to parse condition
> WixBundleInstalled OR (((VersionNT >= v6.1) OR (VersionNT64 >= 6.1)) AND
> (ServicePackLevel >= 1)). Unexpected symbol at position (null)
> [2484:695C][2019-05-14T22:57:04]i000: The data is invalid. (Exception from
> HRESULT: 0x8007000D)
> [2484:695C][2019-05-14T22:57:04]i199: Detect complete, result: 0x0
> [2484:0F24][2019-05-14T22:57:04]i000: Initializing telemetry manager
>
> The i000 entries are all from my custom BA.
>
> Thanks,
> Jacques
>
>
>