[wix-users] Official 3.14 release date
Ivan Peev
ivan.peev at gmail.com
Mon Jun 17 04:31:59 PDT 2019
Christopher,
Isn't it easier to fix the WiX runtime instead? I was thinking either
remove the fix included for 5597 or including
"Microsoft.VisualStudio.Product.SQL" SKU in the list below. Still, in my
opinion, the fix for 5597 has to be better analyzed whether this is the
right approach even though vswhere has been used as the template for it. I
think this fix is more harmful than helpful.
On Mon, Jun 17, 2019 at 7:05 AM Christopher Painter <chrpai at iswix.com>
wrote:
> I already provided sample code from my repos on how to work around this.
>
>
> ------------------------------
> *From:* Ivan Peev <ivan.peev at gmail.com>
> *Sent:* Sunday, June 16, 2019 10:40 PM
> *To:* Christopher Painter
> *Cc:* Rob Mensching; WiX Toolset Users Mailing List
> *Subject:* Re: [wix-users] Official 3.14 release date
>
> Hi Christopher,
>
> I found what is the issue. The issue is caused by the fix made for 5597 by
> Heath. Now there is a list of recognized VS versions defined
> in rgwzProducts list:
>
> static LPCWSTR rgwzProducts[] =
> {
> L"Microsoft.VisualStudio.Product.Community",
> L"Microsoft.VisualStudio.Product.Professional",
> L"Microsoft.VisualStudio.Product.Enterprise",
> };
>
> and when a valid product SKU like this
> appears: Microsoft.VisualStudio.Product.SQL
>
> it is not recognized. I suspect this issue will not appear under VS 2019
> because SSDT is now installed as VS extension and no longer distributed as
> separate VS SKU. So the main issue now appears how to properly handle the
> legacy VS 2017 installations. Looking forward to hearing your feedback.
>
> On Wed, Jun 12, 2019 at 12:41 PM Christopher Painter <chrpai at iswix.com>
> wrote:
>
> They were related. I originally extended the 2017 pattern to support 2018.
> Then there was a scenario where if 2017 and 2019 were both installed one or
> the their wouldn’t be detected. Heath saw and fixed the issue.
>
> The code in my repos added 2019 detection to an msi build with 3.11 so
> that should work for you.
>
> Sent from my iPhone
>
> On Jun 12, 2019, at 11:17 AM, "ivan.peev at gmail.com" <ivan.peev at gmail.com>
> wrote:
>
> Hi Chris,
>
> This is valuable information. Thank you! We will try your recommendations.
>
> Quick question. Was the last change made related to VS 2019 the reason the
> detection for VS 2017 has stopped working? Or there is a different commit
> which is the reason?
>
> On Jun 12, 2019, at 12:01 PM, Christopher Painter <chrpai at iswix.com>
> wrote:
>
> Rob,
>
> I'm going to have to amend my position. The SSDT is a flavor of VS2017.
> An obscure purpose built one.... that said, The VS2017 Votive
> integrates just fine with it and I'm able to create and build a WiX
> project. Also an older version of IsWiX built using WiX 3.11 also detects
> and integrates just fine with it it also. I though it was going to be more
> like SSMS but it brings more along for the ride then just using the VSIDE
> as a shell. I would suggest considering having the VSEXT detect this as
> a qualifying product as WiX 3.11 did.
>
> VS2017/2019 with it's various workloads/payloads and multipe side by side
> instance installations does pose a problem for this whole extension and
> setup developers in general. I've managed to keep carrying on the way I
> always have but I can see why you split Votive out of the installer and
> into it's own VSIX packages. Ivan might want to consider that also.
>
>
> Ivan,
>
> I don't know that WiX will have an answer for this in the short term. I
> do have some code that I can share with you that can be scheduled after
> WiX's custom action and before AppSearch that will help you with your
> problem. This would be a work around and you'd wan't to remove it if a
> future version of WiX handles this on it's own.
>
> You'd basically want:
>
> <Binary Id="iswixActions"
> SourceFile="$(var.IsWiXActions.TargetDir)IsWiXActions.CA.dll"/>
> <CustomAction Id="VSFindInstances2" BinaryKey="iswixActions"
> DllEntry="VSFindInstances2" Execute="firstSequence"/>
> <InstallUISequence>
> <Custom Action="VSFindInstances2" After="VSFindInstances"></Custom>
> </InstallUISequence>
> <InstallExecuteSequence>
> <Custom Action="VSFindInstances2" After="VSFindInstances"></Custom>
> </InstallExecuteSequence>
>
>
> And the code found here:
> https://raw.githubusercontent.com/iswix-llc/iswix/ec783111c60708f697202ae16b8e0318bbed7bc4/Installer/IsWiXActions/CustomAction.cs
>
>
> Consulting services are available if you want hands on assistance
> integrating this into your solution.
>
> Chris
>
>
> ------------------------------
> *From:* Christopher Painter
> *Sent:* Wednesday, June 12, 2019 5:58 AM
> *To:* Ivan Peev
> *Cc:* Rob Mensching; WiX Toolset Users Mailing List
> *Subject:* Re: [wix-users] Official 3.14 release date
>
> It isn't Visual Studio. It's Microsoft SQL Server Data Tools for Visual
> Studio 2017.
>
> If you have an AddIn that works with this MSFT SKU and think there is a
> use case for WiX to support it submit an issue on GitHub and/or a WIP to
> the wix-devs mailing list.
>
> ------------------------------
> *From:* Ivan Peev <ivan.peev at gmail.com>
> *Sent:* Tuesday, June 11, 2019 10:43 PM
> *To:* Christopher Painter
> *Cc:* Rob Mensching; WiX Toolset Users Mailing List
> *Subject:* Re: [wix-users] Official 3.14 release date
>
> Christopher,
>
> When I ran vswhere -products * I've got the following output:
>
> Visual Studio Locator version 2.1.3 [query version 1.12.134.36697]
> Copyright (C) Microsoft Corporation. All rights reserved.
>
> instanceId: baa75a2e
> installDate: 10/23/2017
> installationName: VisualStudio/15.4.1+27004.2005
> installationPath: C:\Program Files (x86)\Microsoft Visual Studio\2017\SQL
> installationVersion: 15.4.27004.2005
> isPrerelease: 0
> displayName: Microsoft SQL Server Data Tools for Visual Studio 2017
> description: Microsoft SQL Server Data Tools for Visual Studio 2017
> enginePath: C:\Program Files (x86)\Microsoft Visual
> Studio\Installer\resources\app\ServiceHub\Services\Microsoft.VisualStudio.Setup.Service
> channelId: VisualStudio.15.Release
> channelPath:
> C:\Users\test\AppData\Local\Microsoft\VisualStudio\Packages\_Channels\4CB340F5\catalog.json
> channelUri: https://aka.ms/vs/15/release/channel
> releaseNotes: https://go.microsoft.com/fwlink/?LinkId=660692#15.4.1
> thirdPartyNotices: https://go.microsoft.com/fwlink/?LinkId=660708
>
> On Tue, Jun 11, 2019 at 10:06 PM <ivan.peev at gmail.com> wrote:
>
> Christopher,
>
> This is Visual Studio. Our application includes an extension which
> integrates inside Visual Studio.
>
> On Jun 11, 2019, at 7:53 PM, Christopher Painter <chrpai at iswix.com> wrote:
>
> Do you understand the download link you sent me was for SQL Server Data
> Tools and not Visual Studio?
>
> You aren't actually installing VS 2017. Your just installing a product
> that uses parts of VS for it's solution.
>
> Perhaps if you step back a second and explain what your application is and
> what's it's dependencies / integrations are we could get some information
> over to Heath and see if anything could be done to accommodate it.
>
> If you do a vswhere.exe -products * you'll see an output that shows you
> have Microsoft.VisualStudio.Product.SQL
> not Microsoft.VisualStudio.Product.Community
>
>
>
>
> ------------------------------
> *From:* Ivan Peev <ivan.peev at gmail.com>
> *Sent:* Tuesday, June 11, 2019 12:36 PM
> *To:* Rob Mensching
> *Cc:* Christopher Painter; WiX Toolset Users Mailing List
> *Subject:* Re: [wix-users] Official 3.14 release date
>
> Christopher,
>
> What should we do next? It is obvious the issue is with WiX.
>
> To get an environment where you can reproduce the issue yourself,
> configure a clean VM and then install the VS-based tool from here
> <https://go.microsoft.com/fwlink/?LinkId=871368>. You should now have the
> same environment you claim it is corrupt but it is not. Try to build an
> installer with the old WiX 3.11 and then you will see it works properly on
> it. Waiting for your feedback.
>
> On Tue, Jun 11, 2019 at 9:35 AM <ivan.peev at gmail.com> wrote:
>
> Hi Rob,
>
> I can confirm the issue is with WiX 3.14 beta. If I use WiX 3.11 to build
> the Installer, VS 2017 is recognized properly. However if I use WiX 3.14
> beta to get support for VS 2019, then the discovery for VS 2017 is broken.
> The bug is definitely in the WiX code.
>
> On Jun 11, 2019, at 9:12 AM, Rob Mensching <rob at firegiant.com> wrote:
>
> Ivan,
>
>
>
> The mechanism for locating VS installations changed radically in VS2017
> (and remained in VS2019). Finding those installations is dependent on the
> same code that is used by vswhere.exe to locate VS2017 and VS2019. If
> vswhere.exe cannot see your installations on a machine, then the WiX based
> CustomActions to find VS will not find them either.
>
>
>
> IIRC, there was a bug (that I did not follow closely) in the VS location
> code when both VS2017 and VS2019 were installed. So, it is definitely
> possible there is another bug.
>
>
>
> However, if vswhere.exe cannot find VS then that is definitely the place
> to start. The Visual Studio team owns vswhere.exe (and the VS dev that
> works vshwere.exe updated the WiX CustomAction to call the same API) so
> you'll want to follow up with Visual Studio first, to understand why VS2017
> is hiding from vswhere.exe.
>
>
>
> Once vswhere.exe can see the VS installations, then there is a chance the
> CustomAction will be able to find it as well.
>
>
>
>
>
> Regards,
>
>
>
> Rob Mensching
>
> CEO
>
> FireGiant
>
> _______________________________________________________________
>
> FireGiant | Dedicated support for the WiX toolset |
> http://www.firegiant.com/
>
>
>
> *From:* ivan.peev at gmail.com <ivan.peev at gmail.com>
> *Sent:* Tuesday, June 11, 2019 6:01 AM
> *To:* Christopher Painter <chrpai at iswix.com>
> *Cc:* Rob Mensching <rob at firegiant.com>; WiX Toolset Users Mailing List <
> wix-users at lists.wixtoolset.org>
> *Subject:* Re: [wix-users] Official 3.14 release date
>
>
>
> Christopher,
>
>
>
> You are wrong . The installation is not corrupt. I have already stated I
> have tested on clean machine and I have tested on multiple VS 2017
> versions. WiX 3.11 handles VS 2017 installation properly. WiX 3.14 beta
> breaks the support.
>
>
> On Jun 11, 2019, at 8:48 AM, Christopher Painter <chrpai at iswix.com> wrote:
>
> You have a corrupt installation of Visual Studio. It should display a lot
> of information. Try running the VS Installer and see if it wan't any
> repair actions or anything.
>
>
>
>
>
>
> ------------------------------
>
> *From:* Ivan Peev <ivan.peev at gmail.com>
> *Sent:* Tuesday, June 11, 2019 6:52 AM
> *To:* Christopher Painter
> *Cc:* Rob Mensching; WiX Toolset Users Mailing List
> *Subject:* Re: [wix-users] Official 3.14 release date
>
>
>
> Christopher,
>
>
>
> This is the only printout:
>
>
>
> Visual Studio Locator version 2.1.3 [query version 1.12.134.36697]
> Copyright (C) Microsoft Corporation. All rights reserved.
>
>
>
> On Tue, Jun 11, 2019 at 7:49 AM Christopher Painter <chrpai at iswix.com>
> wrote:
>
> Please run C:\Program Files (x86)\Microsoft Visual
> Studio\Installer\vswhere.exe and post the results.
>
>
>
>
> ------------------------------
>
> *From:* Ivan Peev <ivan.peev at gmail.com>
> *Sent:* Monday, June 10, 2019 8:46 PM
> *To:* Christopher Painter
> *Cc:* Rob Mensching; WiX Toolset Users Mailing List
> *Subject:* Re: [wix-users] Official 3.14 release date
>
>
>
> Christopher,
>
>
>
> Find attached the log file.
>
>
>
> On Mon, Jun 10, 2019 at 6:25 PM Christopher Painter <chrpai at iswix.com>
> wrote:
>
> If you don't mind, please log the installation of:
>
>
>
> https://github.com/iswix-llc/iswix/releases/tag/v4.14.5
>
>
>
> Just get to the welcome dialog and cancel out. You don't need to install
> all the way.
>
>
>
>
>
>
> ------------------------------
>
> *From:* Ivan Peev <ivan.peev at gmail.com>
> *Sent:* Monday, June 10, 2019 5:12 PM
> *To:* Christopher Painter
> *Cc:* Rob Mensching; WiX Toolset Users Mailing List
> *Subject:* Re: [wix-users] Official 3.14 release date
>
>
>
> Christopher,
>
>
>
> Please tell me what tables I should check. Isn't AppSearch command done by
> the WiX engine?
>
>
>
> On Mon, Jun 10, 2019 at 5:59 PM Christopher Painter <chrpai at iswix.com>
> wrote:
>
> I see the differences in the log including the MSI name was different.
>
>
>
> I don't know how these were built. Have you compared the databases using
> ORCA and compared the relevant tables?
>
>
>
>
>
>
> ------------------------------
>
> *From:* Ivan Peev <ivan.peev at gmail.com>
> *Sent:* Sunday, June 9, 2019 9:23 PM
> *To:* Christopher Painter
> *Cc:* Rob Mensching; WiX Toolset Users Mailing List
> *Subject:* Re: [wix-users] Official 3.14 release date
>
>
>
> Hi Christopher,
>
>
>
> I'm not talking about the WiX plugin for VS 2019. The issue is
> VS2017DEVENV property is not available during installation on system with
> VS 2017. If I run the installer on a system with VS 2019, VS2019DEVENV
> property is available.
>
>
>
> If I go back to WiX 3.11, VS2017DEVENV property is again working properly
> when running on VS 2017 system.
>
>
>
> On Sun, Jun 9, 2019 at 10:10 PM Christopher Painter <chrpai at iswix.com>
> wrote:
>
> I have VS2019 15.9.4 installed on my build server with the 1.0.0.2 WiX VS
> 2017 extension and WiX 3.14.0.2927 installed. Everything works just fine.
>
>
> ------------------------------
>
> *From:* Ivan Peev <ivan.peev at gmail.com>
> *Sent:* Sunday, June 9, 2019 4:32 PM
> *To:* Christopher Painter
> *Cc:* Rob Mensching; WiX Toolset Users Mailing List
> *Subject:* Re: [wix-users] Official 3.14 release date
>
>
>
> Hi Rob,
>
>
>
> It appears my conclusion was too quick. The support for VS 2019 is working
> fine. However, the support for VS 2017 is now broken. I have tested with
> the following VS 2017 versions - 15.9.9, 15.8.6, 15.5.2, 15.4.1
>
>
>
> I have done the test on a clean machine with no other VS version installed
> on it. After I went back to WiX 3.11, the installation is again working
> properly for VS 2017. Version 3.14.0.2927 is broken.
>
>
>
>
>
>
>
> On Tue, May 28, 2019 at 8:16 AM Christopher Painter <chrpai at iswix.com>
> wrote:
>
> Ah, I was looking at https://wixtoolset.org/releases/ since it had the
> 1.0.0.2 of 2019.
>
>
>
> I've installed all of them and 3.14 on my build box and 3.14 and updated
> IsWiX to use the 2019 detection feature in 3.14 and everything looks good
> to me.
>
>
>
> The only thing of note is how much smaller the 2010-2015 versions of the
> extension are and how quickly they installed. I had an initial sense that
> they were missing something and the installation success was a false
> positive but everything seems to be there just fine.
>
>
>
>
> ------------------------------
>
> *From:* Rob Mensching <rob at firegiant.com>
> *Sent:* Tuesday, May 28, 2019 12:10 AM
> *To:* Christopher Painter; Ivan Peev
> *Cc:* WiX Toolset Users Mailing List
> *Subject:* RE: [wix-users] Official 3.14 release date
>
>
>
> Yes. VS2017 (and all the others) exist here:
> https://github.com/wixtoolset/VisualStudioExtension/releases/tag/v1.0.0.2
>
>
>
> _____________________________________________________________
>
> Short replies here. Complete answers over there: http://www.firegiant.com/
>
>
>
> *From:* Christopher Painter <chrpai at iswix.com>
> *Sent:* Monday, May 27, 2019 7:35 PM
> *To:* Rob Mensching <rob at firegiant.com>; Ivan Peev <ivan.peev at gmail.com>
> *Cc:* WiX Toolset Users Mailing List <wix-users at lists.wixtoolset.org>
> *Subject:* Re: [wix-users] Official 3.14 release date
>
>
>
> Rob:
>
>
>
> RE the VS2019 extension and the item template issue... does that need a
> new build of the VS2017 extension also?
>
>
More information about the wix-users
mailing list