[wix-users] ConfiguresmbUninstall is failing when 'Installing' on French system.

[Douglas, Keith (STATCAN)]

For what (little) it is worth and by analogy, when designing some UIs for our front end there were occasionally places where I found that WiX's documentation did not explain lengths etc. I have a list of these somewhere. 72 for IDs I think was one I sort of guessed was a thing.

 

Keith Douglas

Programmer Analyst, Collection Systems Division
Statistics Canada / Government of Canada
Keith.Douglas at canada.ca / Tel : 613-854-5589

Programmeur analyste, Division des systèmes de collecte
Statistique Canada / Gouvernenment du Canada
Keith.Douglas at canada.ca / Tél :613-854-5589

-----Original Message-----
From: wix-users [mailto:wix-users-bounces at lists.wixtoolset.org] On Behalf Of Phill Hogland
Sent: June-22-16 12:45 PM
To: WiX Toolset Users Mailing List <wix-users at lists.wixtoolset.org>
Subject: Re: [wix-users] ConfiguresmbUninstall is failing when 'Installing' on French system.


Thanks for everyone's comments!

I have been reading back through the code to try and understand the information and learn to decipher this myself.  It lloks to me like a bug (rather than enhancement) in scasmb.h where the wzDescription in the struct is defined as:

WCHAR wzDescription[MAX_DARWIN_KEY + 1];  ( and in wiutil.h #define MAX_DARWIN_KEY 73 )

However the FileShare table is defined as a
<columnDefinition name="Description" type="string" length="255" nullable="yes"  category="text" description="Description string displayed for the file share"/>

I also observe that SCA_WEB struct in scaweb.h has wzDescription defined as:
    WCHAR wzDescription[MAX_DARWIN_COLUMN + 1]; (and in wiutil.h #define MAX_DARWIN_COLUMN 255 ).

So I am guessing that SCA_SMB structure should have also used MAX_DARWIN_COLUMN  to define wzdescription, and it is probably just a cut and paste error that has been unnoticed until now.

I am in the process of rebuilding my projects after imposing a more succinct description in my French and Spanish speaking folks, as a test, but I think Bob has identified the problem.  After I complete those tests I will open an issue report.

________________________________________
From: wix-users <wix-users-bounces at lists.wixtoolset.org> on behalf of Rob Mensching <rob at firegiant.com>
Sent: Wednesday, June 22, 2016 11:21:52 AM
To: WiX Toolset Users Mailing List
Subject: Re: [wix-users] ConfiguresmbUninstall  is      failing when    'Installing'    on      French system.

Yes. Although 72 characters should only be a limit for Ids. We should have more reasonable limits (or no limits) for arbitrary strings.

_____________________________________________________________
 Short replies here. Complete answers over there: http://www.firegiant.com/


-----Original Message-----
From: wix-users [mailto:wix-users-bounces at lists.wixtoolset.org] On Behalf Of Hoover, Jacob
Sent: Wednesday, June 22, 2016 8:57 AM
To: WiX Toolset Users Mailing List <wix-users at lists.wixtoolset.org>
Subject: Re: [wix-users] ConfiguresmbUninstall is failing when 'Installing' on French system.

Shouldn't we be generating an error if a user is passing in a string longer than 72 then?

____________________________________________________________________
WiX Toolset Users Mailing List provided by FireGiant http://www.firegiant.com/

____________________________________________________________________
WiX Toolset Users Mailing List provided by FireGiant http://www.firegiant.com/