[wix-devs] Pull Request Question

[Hoover, Jacob]

If it was squash merged, then it would have combined all your commits into a single commit (with a new hash).


From: Christopher Painter <chrpai at iswix.com>
Sent: Thursday, March 24, 2022 1:46 PM
To: Hoover, Jacob <Jacob.Hoover at greenheck.com>; WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Subject: Re: Pull Request Question

It's not the hash from my PR and my PR doesn't indicate it was merged.
________________________________
From: Hoover, Jacob <Jacob.Hoover at greenheck.com<mailto:Jacob.Hoover at greenheck.com>>
Sent: Thursday, March 24, 2022 1:44 PM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org<mailto:wix-devs at lists.wixtoolset.org>>
Cc: Christopher Painter <chrpai at iswix.com<mailto:chrpai at iswix.com>>
Subject: RE: Pull Request Question


Bob's comment on the PR has a closed via (hash), which links to: https://github.com/wixtoolset/wix3/commit/9871b1061484ea2d8d1a0e4ea08ae6ce5f064c71<https://github.com/wixtoolset/wix3/commit/9871b1061484ea2d8d1a0e4ea08ae6ce5f064c71>



Is that not the expected change?



From: wix-devs <wix-devs-bounces at lists.wixtoolset.org<mailto:wix-devs-bounces at lists.wixtoolset.org>> On Behalf Of Christopher Painter via wix-devs
Sent: Saturday, March 19, 2022 7:58 PM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org<mailto:wix-devs at lists.wixtoolset.org>>
Cc: Christopher Painter <chrpai at iswix.com<mailto:chrpai at iswix.com>>
Subject: Re: [wix-devs] Pull Request Question



Is this just what squashing does? Sorry if I'm jumping to conclusions.
________________________________
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org<mailto:wix-devs-bounces at lists.wixtoolset.org>> on behalf of Christopher Painter via wix-devs <wix-devs at lists.wixtoolset.org<mailto:wix-devs at lists.wixtoolset.org>>
Sent: Saturday, March 19, 2022 7:53 PM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org<mailto:wix-devs at lists.wixtoolset.org>>
Cc: Christopher Painter <chrpai at iswix.com<mailto:chrpai at iswix.com>>
Subject: [wix-devs] Pull Request Question

So I took on an issue and submitted a PR:

https://github.com/wixtoolset/wix3/pull/542<https://github.com/wixtoolset/wix3/pull/542>

This issue and PR was closed and I don't show in the commit history because my PR wasn't actually merged. It's like my work was ignored or just taken without credit.

Was there something wrong with my code? Have I missed anything? I see other people in the commit history other than the three main people so I don't think this is always the pattern.
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/<http://www.firegiant.com>
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/<http://www.firegiant.com/>

NOTE: This email was received from an external source. Please use caution when opening links or attachments in the message.
NOTE: This email was received from an external source. Please use caution when opening links or attachments in the message.