[wix-devs] Pull Request Question
Christopher Painter
chrpai at iswix.com
Sat Mar 19 17:57:53 PDT 2022
Is this just what squashing does? Sorry if I'm jumping to conclusions.
________________________________
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> on behalf of Christopher Painter via wix-devs <wix-devs at lists.wixtoolset.org>
Sent: Saturday, March 19, 2022 7:53 PM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Cc: Christopher Painter <chrpai at iswix.com>
Subject: [wix-devs] Pull Request Question
So I took on an issue and submitted a PR:
https://github.com/wixtoolset/wix3/pull/542
This issue and PR was closed and I don't show in the commit history because my PR wasn't actually merged. It's like my work was ignored or just taken without credit.
Was there something wrong with my code? Have I missed anything? I see other people in the commit history other than the three main people so I don't think this is always the pattern.
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/
More information about the wix-devs
mailing list