[wix-devs] nuget.config

[Rob Mensching]

[keeping wix-devs mailing list on the thread]

+1

Honestly, it'd probably be better to start with developer documentation in the wix4/README.md. Eventually, the wix4/README.md should look like the other "big projects" but starting with this content is as good as a place as any. <smile/>


-----Original Message-----
From: Mark Stega <mark at optimiumhealth.com> 
Sent: Monday, January 17, 2022 9:36 AM
To: Rob Mensching <rob at firegiant.com>
Subject: RE: nuget.config

Rob,

Thanks for the info -- I didn't want to touch something that might have been important (and obviously was).

Is the intent for WiX4 documentation to follow the same pattern as WiX3? I could start documenting little nuggets of information like doing a "build" rather than build_official...

-----Original Message-----
From: Rob Mensching <rob at firegiant.com> 
Sent: Monday, January 17, 2022 12:28 PM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Cc: Mark Stega <mark at optimiumhealth.com>
Subject: RE: nuget.config

> This creates a delta for nuget.config as the content is slightly reordered in nuget_official.

That is correct. The delta is important.

> I was very careful not to commit nuget.config since

You should not be building an "official build" locally. Only for the build machines do official builds. You should run the "build.cmd" from the root.

> 1) Just bring the two files in sync by committing nuget.config after  the copy occurs in a build

No, that would defeat the goal that the official WiX build use nuget.org binaries before trying to use local built files.

> 2) Make nuget.config an artifact of the build, deleting it from the repository and then updating .gitignore in the "WiX specific ignores" section

The current nuget.config is set for development. The only time a delta should be encountered is on build machiens where the build VM is thrown away at the end. I think the process is optimized correctly right now.


-----Original Message-----
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of Mark Stega via wix-devs
Sent: Monday, January 17, 2022 9:13 AM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Cc: Mark Stega <mark at optimiumhealth.com>
Subject: [wix-devs] nuget.config

In the Wix4 repository there are two files, nuget_official.config & nuget.config. Early in a 'src\build_official' there is an unconditional copy of nuget_official.config to nuget.config. This creates a delta for nuget.config as the content is slightly reordered in nuget_official.

When I was working on the version info for help, I was very careful not to commit nuget.config since what I was doing had nothing to do with nuget, so each time before committing I would discard the changes to nuget.config.

I'd like to propose that one of two things be done:
     1) Just bring the two files in sync by committing nuget.config after  the copy occurs in a build
     2) Make nuget.config an artifact of the build, deleting it from the repository and then updating .gitignore in the "WiX specific ignores" section 

I have a new branch open for the work that I am doing on issue #6681 so I could do either as a 'side effect' of the #6681 work.
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/