[wix-devs] MsiE2E Issue

[Ron Martin]

Sean,

That's exactly what I did. It was not a blocker for me. I just thought 
that I
would illustrate the fact that I had considered, accounted for, and tested
the functionality of a feature not likely to ever be documented.

I'm moving closer to another pull request.

Thanks.

Ron

On 8/25/2022 5:17 PM, Sean Hall via wix-devs wrote:
> The end-to-end tests are concerned about runtime behavior. Localization is
> a build-time feature, so no one has invested the time to support it in the
> E2E tests yet. I'm not sure why this should be a blocker since it should be
> very easy to change your test's MSI to not use localization.
>
> On Thu, Aug 25, 2022 at 2:39 PM Ron Martin via wix-devs <
> wix-devs at lists.wixtoolset.org> wrote:
>
>> Sean,
>>
>> Thanks for responding. So, I take it that PackageInstaller was not
>> specified to enable the testing of
>> localization. I had no trouble getting localization to work, but the
>> test has been giving me grief. I'll
>> remove the test. Perhaps we can add this improvement as a goal for some
>> specific future version
>> of Wix.
>>
>> Ron
>>
>> On 8/25/2022 1:37 PM, Sean Hall via wix-devs wrote:
>>> The file creation is correct in placing the .msi in the en-US folder if
>> you
>>> are building with en-US. Others will have to comment on where its .wixpdb
>>> should be.
>>>
>>> The easy thing to do would be to follow the example of the other tests
>> and
>>> not use localization. The harder option would be to enhance
>>> PackageInstaller to allow specifying the localization name in addition to
>>> the current arguments.
>>>
>>> On Thu, Aug 25, 2022 at 12:32 PM Ron Martin via wix-devs <
>>> wix-devs at lists.wixtoolset.org> wrote:
>>>
>>>> I'm working on an MsiE2E test that I call
>>>> CanCreateNewUserWithLocalizedComment. The test gets to a point where the
>>>> constructor for PackageInstaller is looking for an msi file and a wixpdb
>>>> file in
>>>>
>> D:\Repos\Wix\wix4\build\IntegrationMsi\Debug\netcoreapp3.1\TestData\UtilExtensionUserTests\.
>>>> Unfortunately, those files were actually created in
>>>>
>> D:\Repos\Wix\wix4\build\IntegrationMsi\Debug\netcoreapp3.1\TestData\UtilExtensionUserTests\en-US\.
>>>> It doesn't make sense to me that different .msi files should be created
>>>> for different localizations and not not sure whether the same situation
>>>> applies for .wixpdb files. I need to determine whether to look at the
>>>> file creation or the file reading should be investigated for being
>> wrong.
>>>> Thanks.
>>>>
>>>> Ron
>>>> ____________________________________________________________________
>>>> WiX Toolset Developer Mailing List provided by FireGiant
>>>> http://www.firegiant.com/
>>>>
>>> ____________________________________________________________________
>>> WiX Toolset Developer Mailing List provided by FireGianthttp://
>> www.firegiant.com/
>> ____________________________________________________________________
>> WiX Toolset Developer Mailing List provided by FireGiant
>> http://www.firegiant.com/
>>
> ____________________________________________________________________
> WiX Toolset Developer Mailing List provided by FireGianthttp://www.firegiant.com/