[wix-devs] 5911 - BA Configurable REINSTALLMODE

Fri Sep 3 09:14:48 PDT 2021

I updated the WIP based on this discussion. Any more feedback?

On Wed, Sep 1, 2021 at 8:30 PM Bob Arnson <bob at firegiant.com> wrote:

> I omit C because it's basically useless. Maybe it was interesting in 1999
> when RAM and hard drive space were both measured in MB. Maybe.
>
> I don't have an improved prefix over BOOTSTRAPPER_REINSTALLMODE. I don't
> think it's bad.
>
> -----Original Message-----
> From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of Sean
> Hall via wix-devs
> Sent: Wednesday, 1 September, 2021 21:01
> To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
> Cc: Sean Hall <r.sean.hall at gmail.com>
> Subject: Re: [wix-devs] 5911 - BA Configurable REINSTALLMODE
>
> We need a different name than BOOTSTRAPPER_REINSTALLMODE and reinstallMode
> if it's just an option of O or E or A (and purposely omitting P and D). I
> still don't understand why C isn't part of that, but whatever.
>
> On Wed, Sep 1, 2021 at 6:16 PM Bob Arnson <bob at firegiant.com> wrote:
>
> > I'm suggesting giving the BA control over *only* the
> > (mutually-exclusive) file-versioning switches:
> >
> > > > 3. Let the BA choose one of the file-versioning switches or
> > > > whichever ones we want to support:
> > > >
> > > > P = BOOTSTRAPPER_REINSTALLMODE_MISSING
> > > > O = BOOTSTRAPPER_REINSTALLMODE_MISSING_OR_OLDER (mend) E =
> > > > BOOTSTRAPPER_REINSTALLMODE_MISSING_OR_OLDER_OR_EQUAL (repair) A =
> > > > BOOTSTRAPPER_REINSTALLMODE_ALL_FILES (repair/reinstall) D =
> > > > BOOTSTRAPPER_REINSTALLMODE_MISSING_OR_DIFFERENT
> > > >
> > > > You had O/E/A in the enum and I'd be fine with dropping P (O would
> > > > be
> > > > fine) and D (just do A at that point).
> >
> > O, E, and A are sufficient (imo, so we can skip P & D).
> >
> > Giving control over MUS seems like overkill. Nobody's asked for it and
> > I've never seen it in customized in the wild even outside the context
> > of Burn. So skip 'em (like your WIP -- all the enum values include
> > MUS), give control over file-versioning only, and then there are no
> > combinations to worry about.
> >
> > -----Original Message-----
> > From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of
> > Sean Hall via wix-devs
> > Sent: Wednesday, 1 September, 2021 15:59
> > To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
> > Cc: Sean Hall <r.sean.hall at gmail.com>
> > Subject: Re: [wix-devs] 5911 - BA Configurable REINSTALLMODE
> >
> > > Right but we agreed we don't want to let the BA provide the whole
> > REINSTALLMODE string.
> >
> > I guess I misunderstood. I thought we were going to have a certain set
> > of different combinations of the flags (as I did in the WIP) and the
> > BA could pick any of them, so they would be picking the whole string.
> > If we're letting them pick their own arbitrary combinations of the
> > flags but not the whole string, then it looks to me that "v" is the
> > only one that should be out of the BA's control. All the other ones
> > impact how Windows Installer decides whether or not to install a file,
> shortcut, etc.
> >
> > On Tue, Aug 17, 2021 at 1:15 PM Bob Arnson <bob at firegiant.com> wrote:
> >
> > > Right but we agreed we don't want to let the BA provide the whole
> > > REINSTALLMODE string. I'm just suggesting that we don't need to
> > > provide every possible combination. What the issues have requested
> > > have all been about file versioning rules.
> > >
> > > -----Original Message-----
> > > From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of
> > > Sean Hall via wix-devs
> > > Sent: Tuesday, 17 August, 2021 12:33
> > > To: WiX Toolset Developer Mailing List
> > > <wix-devs at lists.wixtoolset.org>
> > > Cc: Sean Hall <r.sean.hall at gmail.com>
> > > Subject: Re: [wix-devs] 5911 - BA Configurable REINSTALLMODE
> > >
> > > If you remove the enum values with "a" from the WIP, those are the
> > > values currently used by Burn: omus (implicitly by not specifying
> > > REINSTALLMODE during Install), vomus (minor upgrade), cmuse
> > > (Repair), cmuso (Modify/Mend). Burn doesn't already include "c"
> > > every time. It's these kinds of things where I don't think it's
> > > worth it to restrict anything, just let the BA do what it thinks is
> > > best and if they shoot themselves in the foot then so be it.
> > >
> > > On Mon, Aug 16, 2021 at 3:50 PM Bob Arnson <bob at firegiant.com> wrote:
> > >
> > > > Right but I was thinking flag enum values for the bits we want to
> > > > give control over. So, for example, I'd say:
> > > >
> > > > 1. Don't let the BA control "v": It should be omitted for
> > > > first-time installs and is the correct choice for minor upgrades.
> > > > 2. Don't let the BA control "c": Burn already includes it and I
> > > > can't picture a reason to *not* include it.
> > > > 3. Let the BA choose one of the file-versioning switches or
> > > > whichever ones we want to support:
> > > >
> > > > P = BOOTSTRAPPER_REINSTALLMODE_MISSING
> > > > O = BOOTSTRAPPER_REINSTALLMODE_MISSING_OR_OLDER (mend) E =
> > > > BOOTSTRAPPER_REINSTALLMODE_MISSING_OR_OLDER_OR_EQUAL (repair) A =
> > > > BOOTSTRAPPER_REINSTALLMODE_ALL_FILES (repair/reinstall) D =
> > > > BOOTSTRAPPER_REINSTALLMODE_MISSING_OR_DIFFERENT
> > > >
> > > > You had O/E/A in the enum and I'd be fine with dropping P (O would
> > > > be
> > > > fine) and D (just do A at that point).
> > > >
> > > > -----Original Message-----
> > > > From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf
> > > > Of Sean Hall via wix-devs
> > > > Sent: Monday, 16 August, 2021 10:04
> > > > To: WiX Toolset Developer Mailing List
> > > > <wix-devs at lists.wixtoolset.org>
> > > > Cc: Sean Hall <r.sean.hall at gmail.com>
> > > > Subject: Re: [wix-devs] 5911 - BA Configurable REINSTALLMODE
> > > >
> > > > I thought we decided to restrict the set of possible values during
> > > > the meeting discussion. Which is why the WIP has "Providing an
> > > > enum instead of letting the BA pick an arbitrary string is a
> > > > compromise between giving the BA full control over REINSTALLMODE
> > > > and giving it no
> > > control."
> > > >
> > > > On Sun, Aug 15, 2021 at 9:55 PM Bob Arnson <bob at firegiant.com>
> wrote:
> > > >
> > > > > It should be a bit mask, no? Or are you avoiding that to
> > > > > restrict the set of possible values?
> > > > >
> > > > > -----Original Message-----
> > > > > From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf
> > > > > Of Sean Hall via wix-devs
> > > > > Sent: Wednesday, 4 August, 2021 17:51
> > > > > To: WiX Toolset Developer Mailing List
> > > > > <wix-devs at lists.wixtoolset.org>
> > > > > Cc: Sean Hall <r.sean.hall at gmail.com>
> > > > > Subject: [wix-devs] 5911 - BA Configurable REINSTALLMODE
> > > > >
> > > > > I created a WIP for 5911 at
> > > > > https://wixtoolset.org/development/wips/5911-ba-configurable-rei
> > > > > ns
> > > > > ta
> > > > > ll
> > > > > mode
> > > > > .
> > > > > Any feedback?
> > > > > ________________________________________________________________
> > > > > __ __ WiX Toolset Developer Mailing List provided by FireGiant
> > > > > http://www.firegiant.com/
> > > > >
> > > > __________________________________________________________________
> > > > __ WiX Toolset Developer Mailing List provided by FireGiant
> > > > http://www.firegiant.com/
> > > >
> > > ____________________________________________________________________
> > > WiX Toolset Developer Mailing List provided by FireGiant
> > > http://www.firegiant.com/
> > >
> > ____________________________________________________________________
> > WiX Toolset Developer Mailing List provided by FireGiant
> > http://www.firegiant.com/
> >
> ____________________________________________________________________
> WiX Toolset Developer Mailing List provided by FireGiant
> http://www.firegiant.com/
>