[wix-devs] Issue #6262

[Rob Mensching]

Adding wix-devs (best place to ask development questions so others benefit from learning).

From: Rob Mensching
Sent: Saturday, March 20, 2021 12:17 PM
To: Ron Martin <cpuwzd at comcast.net>
Subject: RE: Issue #6262

1. Make sure you comment on the issue that you'd like to start working on it. That minimizes the chance of multiple people working on the same issue at the same time.

2. In a galaxy far far away, $ was used instead of ! on loc variables. So, old code looked like "$(loc.FromWxlFile)" but now should look like "!(loc.FromWxlFile)".  Ultimately, the fix should live in this file: https://github.com/wixtoolset/Converters/blob/master/src/WixToolset.Converters/WixConverter.cs

You can start by adding a test Fixture.cs like this: https://github.com/wixtoolset/Converters/blob/master/src/test/WixToolsetTest.Converters/PropertyFixture.cs

With a reference to loc variable using the "$" syntax.

Writing converter tests is super easy because it is all based on strings.


Regards,

  Rob Mensching
  CEO
  FireGiant
_______________________________________________________________
FireGiant  |  Dedicated support for the WiX toolset  |  http://www.firegiant.com/

From: Ron Martin <cpuwzd at comcast.net<mailto:cpuwzd at comcast.net>>
Sent: Friday, March 19, 2021 8:26 PM
To: Rob Mensching <rob at firegiant.com<mailto:rob at firegiant.com>>
Subject: Issue #6262


Rob,

I'm looking at Issue #6262, as you suggested. I'm afraid I don't have the required historical perspective as to whether all the documentation I'm looking at shows only the current usage or only the deprecated usage. I see "$" used in places like environment variable references and "!" used in places such as linker variable references. Just which usages have been deprecated?

Thanks.

Ron Martin