[wix-devs] 5980 - ResolveSource not working

[Sean Hall]

Requiring an hWnd on Apply() sounds good to me.

I think we need to default to INSTALLUILEVEL_NONE by itself if the display
is not BOOTSTRAPPER_DISPLAY_PASSIVE or BOOTSTRAPPER_DISPLAY_FULL. You think
dropping INSTALLUI_SOURCERESONLY could have side effects?

On Mon, May 18, 2020 at 2:32 PM Rob Mensching <rob at firegiant.com> wrote:

> Given restart handling needs a window to prevent restarts, I lean towards
> requiring an hWnd on Apply(). Although, I could easily be convinced that
> passing NULL hWnd removes the INSTALLUILEVEL_SOURCRESONLY... but I wonder
> if there aren't more side effects when not prompting for source resolution
> (other than simple failure).
>
>
> -----Original Message-----
> From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of Sean
> Hall via wix-devs
> Sent: Sunday, May 17, 2020 3:45 PM
> To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
> Cc: Sean Hall <r.sean.hall at gmail.com>
> Subject: Re: [wix-devs] 5980 - ResolveSource not working
>
> I updated the issue with my findings. Apparently Windows Installer doesn't
> allow programmatically resolving source, so I assume v3 added
> INSTALLUILEVEL_SOURCERESONLY to give the user the chance to resolve it and
> subscribes to the INSTALLLOGMODE_RESOLVESOURCE just out of curiosity.
>
> How should Burn prevent the combination of a NULL hWnd from Apply and
> setting the internal UI level to INSTALLUILEVEL_NONE |
> INSTALLUILEVEL_SOURCERESONLY? Require non-NULL hWnd in Apply? Only allow
> NULL hWnd in Apply if no packages have that uiLevel? Automatically remove
> INSTALLUILEVEL_SOURCERESONLY from uiLevel if NULL hWnd? Something else?
>
> On Sat, May 16, 2020 at 8:12 PM Sean Hall <r.sean.hall at gmail.com> wrote:
>
> > While working on the DisplayInternalUI stuff,
> > https://github.com/wixtoolset/issues/issues/5980 came up in one of my
> > searches. In v3 during uninstallation, we always call
> > MsiSetMsiSetExternalUI(Record) with the uiLevel of INSTALLUILEVEL_NONE
> > | INSTALLUILEVEL_SOURCERESONLY. But we also include
> > INSTALLLOGMODE_RESOLVESOURCE in our message filter. Why are we asking
> > for resolve source messages when we're setting the uiLevel such that
> > we want Windows Installer to handle resolving source?
> >
> ____________________________________________________________________
> WiX Toolset Developer Mailing List provided by FireGiant
> http://www.firegiant.com/
>