[wix-devs] 5355 - util:RegistrySearch clears the variable when the key or value is not found

[Bob Arnson]

Yes. Documentation is the worst way to *only* warn for changes like this. WixCop is at least contextual.

-----Original Message-----
From: Rob Mensching <rob at firegiant.com> 
Sent: Tuesday, 30 June, 2020 13:02
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Cc: Bob Arnson <bob at firegiant.com>
Subject: RE: [wix-devs] 5355 - util:RegistrySearch clears the variable when the key or value is not found

Bob, are you saying "wix convert" should warn on all Bundle searches that the behavior changed?

I think we may just need to start collecting a documentation page that lists breaking changes that can't be converted. Burn will already have the bulk of entries since we're not converting procedural source code.

-----Original Message-----
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of Bob Arnson via wix-devs
Sent: Friday, June 26, 2020 4:53 PM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Cc: Bob Arnson <bob at firegiant.com>
Subject: Re: [wix-devs] 5355 - util:RegistrySearch clears the variable when the key or value is not found

Probably they wouldn't, but they might have which would be a behavior change that might be breaking. It's a general problem: When we make breaking changes, should we add warnings to wix-convert? It seems like the best place. 

-----Original Message-----
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of Sean Hall via wix-devs
Sent: Friday, 26 June, 2020 18:42
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Cc: Sean Hall <r.sean.hall at gmail.com>
Subject: Re: [wix-devs] 5355 - util:RegistrySearch clears the variable when the key or value is not found

Do we need a warning? I have a hard time coming up with a scenario where someone would actually want the current behavior. If they were only interested in the value from the search, then they wouldn't have set a default value in the variable. If they actually wanted the proposed behavior, then they would have a workaround that should still work with the behavior change.

On Sat, Jun 27, 2020 at 4:22 AM Bob Arnson <bob at firegiant.com> wrote:

> I also think it's an excellent proposal. I'm not sure to do in WixCop, 
> other than issue a warning. The typical workaround in v3 was to author 
> an "Exists" key for every other, so you could say "FooExists and 
> FooVersion = v1.0" -- that would still work in most cases but could be simplified.
>
> -----Original Message-----
> From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of 
> Sean Hall via wix-devs
> Sent: Thursday, 25 June, 2020 22:26
> To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
> Cc: Sean Hall <r.sean.hall at gmail.com>
> Subject: [wix-devs] 5355 - util:RegistrySearch clears the variable 
> when the key or value is not found
>
> I'd like to get  https://github.com/wixtoolset/issues/issues/5355
> designed since the proposal is technically a breaking change: "Rather 
> than add a Default attribute, maybe the search should work like MSI, 
> where a missing value doesn't overwrite the default." I think the 
> proposal is good, unless someone else wants to do it differently?
> ____________________________________________________________________
> WiX Toolset Developer Mailing List provided by FireGiant 
> http://www.firegiant.com/
>
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/ ____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/