[wix-devs] 4666 - Add support in Burn for versions that aren't valid MSI versions

[Rob Mensching]

By a non-.0 release, do you mean v4.1 or v4.5? We really wouldn't want to take a change the breaks the interface at v4.x.

Honestly, any change to version evaluations is likely to be really disruptive to peoples' expectations. There might be changes that we could take in a dot-release but I'm hard pressed to think of one. <smile/>

-----Original Message-----
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of Sean Hall via wix-devs
Sent: Sunday, June 28, 2020 3:23 PM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Cc: Sean Hall <r.sean.hall at gmail.com>
Subject: Re: [wix-devs] 4666 - Add support in Burn for versions that aren't valid MSI versions

Yes, this is a very complicated feature that needs to be designed. My interest right now is not to fully design it but design it enough to figure out whether we would take it in a non-.0 release.

On Mon, Jun 29, 2020 at 8:02 AM Bob Arnson <bob at firegiant.com> wrote:

> Sorry, I was talking about bundle versions (mostly). The same caveats 
> apply to MSI package versions that are out of spec (e.g., QWORDable 
> comparisons), however. The best case would be if the versions were 
> still valid as numbers but that wouldn't address all of the complaints.
>
> -----Original Message-----
> From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of 
> Sean Hall via wix-devs
> Sent: Sunday, 28 June, 2020 17:29
> To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
> Cc: Sean Hall <r.sean.hall at gmail.com>
> Subject: Re: [wix-devs] 4666 - Add support in Burn for versions that 
> aren't valid MSI versions
>
> I can't find examples right now, but I know some people have been 
> blocked from using Burn because they're interacting with third-party 
> MSI packages with versions that Burn can't handle. This is what I'm 
> interested in fixing. I expect SemVer to be part of this fix.
>
> On Mon, Jun 29, 2020 at 6:39 AM Bob Arnson <bob at firegiant.com> wrote:
>
> > There's a lot of math in the code that assumes bundle versions are
> QWORDs.
> > Some people want to show versions that are QWORDable but "special"
> > (like leading zeroes and such). Short of SemVer, I'm not sure it's 
> > worth
> a change.
> >
> > -----Original Message-----
> > From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of 
> > Sean Hall via wix-devs
> > Sent: Sunday, 28 June, 2020 01:22
> > To: WiX Toolset Developer Mailing List 
> > <wix-devs at lists.wixtoolset.org>
> > Cc: Sean Hall <r.sean.hall at gmail.com>
> > Subject: [wix-devs] 4666 - Add support in Burn for versions that 
> > aren't valid MSI versions
> >
> > https://github.com/wixtoolset/issues/issues/4666 was written to ask 
> > whether Burn should support semantic versioning. To me, that would 
> > also mean getting Burn not to assume that all versions can be 
> > specified in a QWORD.
> > My intuition tells me that this would be a breaking change. Has 
> > anyone put enough thought into designing this to prove it can be 
> > done in a non-breaking way?