[wix-devs] Change for defect #5395

[Vanniekerk, Tyrel (GE Healthcare)]

Yes, I saw that as well in a related defect where someone thought that text was not being translated.  I am thinking the better solution is to educate our users that when the installer says it need to reboot to continue and you say Ok, you are agreeing that it will reboot.  It's not that unclear.

-----Original Message-----
From: Bob Arnson <bob at firegiant.com> 
Sent: Friday, July 31, 2020 8:44 AM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Cc: Vanniekerk, Tyrel (GE Healthcare) <tyrel.vanniekerk at ge.com>
Subject: EXT: RE: Change for defect #5395

Probably but it wouldn't help the typical case: The StrAllocFromError call above that line gets the default text from Windows. The literal string is used only if that call fails which is pretty unlikely.

-----Original Message-----
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of Vanniekerk, Tyrel (GE Healthcare) via wix-devs
Sent: Friday, 31 July, 2020 09:29
To: wix-devs at lists.wixtoolset.org
Cc: Vanniekerk, Tyrel (GE Healthcare) <tyrel.vanniekerk at ge.com>
Subject: [wix-devs] Change for defect #5395

Hi,

I am responsible for several of our installers that I converted from InstallShield to WiX Toolset.  Some of our service people have complained about the dialog that shows up to tell you that it needs to reboot after installing .NET Framework.  They were surprised that when they clicked OK on a dialog that says the installer needs to reboot to continue, it rebooted.  Probably about as surprised as when a politician does something they said they would do during the elections.  😊

https://github.com/wixtoolset/issues/issues/5395

I got the code to compile using the build guide and had to install a few extra bits for VS 2019, but it seems to work now.  I found the code in question and made the following change.

From:
int nResult = ::MessageBoxW(m_hWnd, sczUnformattedText ? sczUnformattedText : L"The requested operation is successful. Changes will not be effective until the system is rebooted.", m_pTheme->sczCaption, MB_ICONEXCLAMATION | MB_OKCANCEL);

To:
int nResult = ::MessageBoxW(m_hWnd, sczUnformattedText ? sczUnformattedText : L"The requested operation is successful. Changes will not be effective until the system is rebooted.\r\nOK to reboot, Cancel to exit.", m_pTheme->sczCaption, MB_ICONEXCLAMATION | MB_OKCANCEL);

Would this be an acceptable solution to this issue?  If so, I will figure out how to create a pull request etc. to get the change submitted.

Thanks,
Tyrel



____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/