[wix-devs] 6210 - Burn engine should handle non-QWORD versions

[Rob Mensching]

Sounds interesting.

One important facet to keep in mind is that our versions need to have a compare order. Burn and Windows Installer need to know if "-alpha" comes before or after "-beta".

Cloud deployment systems can be a bit different because the deployment is executed by someone knowledgeable of system to know "x" comes after "y" but before "z"... except when the moon is at its zenith.

Burn and MSI packages go out into the wild and need to "self-sort" themselves in the correct order so users unfamiliar with the internal workings can get from v1 to v2 to v3 independently.

Regards,

  Rob Mensching
  CEO
  FireGiant
_______________________________________________________________
FireGiant  |  Dedicated support for the WiX toolset  |  http://www.firegiant.com/

From: Brian Drennan <brian.e.drennan at outlook.com>
Sent: Wednesday, July 22, 2020 3:57 PM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Cc: Rob Mensching <rob at firegiant.com>
Subject: Re: [wix-devs] 6210 - Burn engine should handle non-QWORD versions

Hi all,
My team is currently using service fabric, which doesn't perform any validation on the version strings of packages. We really value the ability to version without any validation of any monikers we come up with. Most of the time, we just use a "-alpha" or "-beta" suffix, but that actually fails certain parsing rules when compiling an assembly in .NET (it works for the informational version, but not the primary version).
My current org doesn't use WiX for anything (yet), but arbitrary strings are a thing we would value. I hope our use case helps with the decision making process. I'd be happy to jump on the next WiX Online Meeting to further discuss if anyone thinks there would be some benefit there.
Regards,
Brian
________________________________
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org<mailto:wix-devs-bounces at lists.wixtoolset.org>> on behalf of Rob Mensching via wix-devs <wix-devs at lists.wixtoolset.org<mailto:wix-devs at lists.wixtoolset.org>>
Sent: Wednesday, July 22, 2020 11:24:55 AM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org<mailto:wix-devs at lists.wixtoolset.org>>
Cc: Rob Mensching <rob at firegiant.com<mailto:rob at firegiant.com>>
Subject: Re: [wix-devs] 6210 - Burn engine should handle non-QWORD versions

Very interesting.  "@#$%^&*" is not valid SemVer nor 4-dotted.

Should there be some indication when parsing that the parsed thing isn't at all recognized as a version?
Is there a use case for arbitrary strings to be treated as "v0-[arbitrarystring]" in version comparisons?


-----Original Message-----
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of Sean Hall via wix-devs
Sent: Friday, July 17, 2020 4:25 PM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Cc: Sean Hall <r.sean.hall at gmail.com>
Subject: Re: [wix-devs] 6210 - Burn engine should handle non-QWORD versions

It would be parsed to

major - 0
minor - 0
patch - 0
revision - 0
release labels - [] (empty array)
metadata - "@#$%^&*<mailto:%22%20in%20version%20comparisons?%0b%0b%0b-----Original%20Message-----%0bFrom:%20wix-devs%20%3cwix-devs-bounces at lists.wixtoolset.org%3e%20On%20Behalf%20Of%20Sean%20Hall%20via%20wix-devs%0bSent:%20Friday,%20July%2017,%202020%204:25%20PM%0bTo:%20WiX%20Toolset%20Developer%20Mailing%20List%20%3cwix-devs at lists.wixtoolset.org%3e%0bCc:%20Sean%20Hall%20%3cr.sean.hall at gmail.com%3e%0bSubject:%20Re:%20[wix-devs]%206210%20-%20Burn%20engine%20should%20handle%20non-QWORD%20versions%0b%0bIt%20would%20be%20parsed%20to%0b%0bmajor%20-%200%0bminor%20-%200%0bpatch%20-%200%0brevision%20-%200%0brelease%20labels%20-%20[]%20(empty%20array)%0bmetadata%20-%20%22@#$%^&*>"

"v0" or "0" or "" are all parsed to

major - 0
minor - 0
patch - 0
revision - 0
release labels - [] (empty array)
metadata - "" (empty string)

"@#$%^&*" would be greater than "v0"

____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.firegiant.com%2F&data=02%7C01%7C%7C02f35b2db1b442b2b34708d82e53661e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637310283005645003&sdata=ga1CVrldfKzFNyw8dyJnU35aNHWEmRj00RL2Y1aAQvg%3D&reserved=0