[wix-devs] 6210 - Burn engine should handle non-QWORD versions

[Sean Hall]

It would be parsed to

major - 0
minor - 0
patch - 0
revision - 0
release labels - [] (empty array)
metadata - "@#$%^&*"

"v0" or "0" or "" are all parsed to

major - 0
minor - 0
patch - 0
revision - 0
release labels - [] (empty array)
metadata - "" (empty string)

"@#$%^&*" would be greater than "v0"


On Sat, Jul 18, 2020 at 9:19 AM Rob Mensching <rob at firegiant.com> wrote:

> > I'm talking about the engine version as a QWORD.
>
> Got it. Agreed.
>
>
> > Yes it will be successfully parsed, that's the whole point of this issue.
>
> What would "@#$%^&*" be parsed to? The equivalent of "v0"?
>
>
> -----Original Message-----
> From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of Sean
> Hall via wix-devs
> Sent: Friday, July 17, 2020 4:17 PM
> To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
> Cc: Sean Hall <r.sean.hall at gmail.com>
> Subject: Re: [wix-devs] 6210 - Burn engine should handle non-QWORD versions
>
> >  use both dotted versions and semver for their new bundles
>
> Yeah, I'm not talking about the bundle version. I'm talking about the
> engine version as a QWORD.
>
> https://github.com/wixtoolset/burn/blob/6d763d9c86405644cc72530ad64978efd6ba5828/src/engine/EngineForApplication.cpp#L407
>
> >  I didn't think "@#$%^&*" would be successfully parsed.
>
> Yes it will be successfully parsed, that's the whole point of this issue.
> Burn can't fail to parse a string as a version no matter how crazy it is.
>