[wix-devs] Burn Variable breaking changes

[Rob Mensching]

I agree with all this but I lean more towards using "string" instead of "literal".

Literal would be a new keyword and given "string" behaves as non-formatted in WiX today, I lean towards just using that.

I could be overruled though.

-----Original Message-----
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of Bob Arnson via wix-devs
Sent: Tuesday, July 14, 2020 5:52 PM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Cc: Bob Arnson <bob at firegiant.com>
Subject: Re: [wix-devs] Burn Variable breaking changes

+1

-----Original Message-----
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of Sean Hall via wix-devs
Sent: Tuesday, 14 July, 2020 20:35
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Cc: Sean Hall <r.sean.hall at gmail.com>
Subject: Re: [wix-devs] Burn Variable breaking changes

I'd be fine with getting rid of "string" and having "formatted" and "literal". We still have to decide the type that gets chosen for you when you author a Variable with a value but not a type. <Variable Name="myvar"
Value="mystring" /> gets coerced to Type="string" today. I'm slowly coming around to "literal" being the default.

On Wed, Jul 15, 2020 at 7:05 AM Bob Arnson via wix-devs < wix-devs at lists.wixtoolset.org> wrote:

> I finally went back to WiX v3 to get a better handle on "literal." I 
> think I much prefer the model of making it its own type.
>
> I really don't have good naming suggestions. I might have a slight 
> preference for "formatted" and "literal" to avoid the discussion of 
> which should be the default.
>
> -----Original Message-----
> From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of 
> Rob Mensching via wix-devs
> Sent: Tuesday, 14 July, 2020 15:54
> To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
> Cc: Rob Mensching <rob at firegiant.com>
> Subject: Re: [wix-devs] Burn Variable breaking changes
>
> I like "formatted" and "string" better than "string" and "literal" 
> better than "string" and "literalString".
>
> But I'm still not sure if best to change "string" to "formatted" but 
> man would it line up with the rest of WiX terminology.
>
> I also like the idea of switch the default to the literal string 
> because that again matches the rest of WiX.
>
> But I'm really interested in other thoughts. My preferences are the 
> most breaking. I'm also curious what Bob thinks of the names. He 
> usually whips out the OED and smacks me about a bit at this point.
>
> -----Original Message-----
> From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of 
> Sean Hall via wix-devs
> Sent: Wednesday, July 8, 2020 5:53 AM
> To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
> Cc: Sean Hall <r.sean.hall at gmail.com>
> Subject: Re: [wix-devs] Burn Variable breaking changes
>
> I created a WIP for this at
> https://wixtoolset.org/development/wips/4863-thmutil-literal-variables/.
> We need to decide on the names and the default.
>
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/ ____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/