[wix-devs] Testing 4x

Tue Jul 14 14:25:47 PDT 2020

So, can we combine "fmt" and "lint"? Or do we need:

wix convert
wix fmt
wix lint

I'd rather not have "wix fmt" and keep the "-f" (fix it) switch on "lint" and, of course, "convert".

-----Original Message-----
From: Bob Arnson <bob at firegiant.com> 
Sent: Tuesday, July 14, 2020 2:05 PM
To: Rob Mensching <rob at firegiant.com>; WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Subject: RE: [wix-devs] Testing 4x

I'm on record as saying that WixCop has three jobs: StyleCop, linter, and converter. Newer languages like Go and Rust solve the problem of style arguments by having one style that's enforced by a "fmt" tool and hey, look, we were doing that for ages before them. I'd be +1 splitting the rules (or enabling/disabling appropriately) to focus on each task.

-----Original Message-----
From: Rob Mensching <rob at firegiant.com>
Sent: Tuesday, 14 July, 2020 15:43
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Cc: Bob Arnson <bob at firegiant.com>
Subject: RE: [wix-devs] Testing 4x

I think the question is whether we should suppress "style-cop" while doing conversion? Enforcing whitespace while converting from v3 to v4 does add a lot noise.

-----Original Message-----
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of Bob Arnson via wix-devs
Sent: Thursday, July 9, 2020 4:32 PM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Cc: Bob Arnson <bob at firegiant.com>
Subject: Re: [wix-devs] Testing 4x

http://www.joyofsetup.com/2008/03/26/wix-goodies-wixcop/

-----Original Message-----
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of Sean Hall via wix-devs
Sent: Thursday, 9 July, 2020 18:18
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Cc: Sean Hall <r.sean.hall at gmail.com>
Subject: Re: [wix-devs] Testing 4x

https://github.com/wixtoolset/Core/blob/220bea1948c19132d0e5277021b967993293c5a3/src/WixToolset.Core/CommandLine/BuildCommand.cs#L548

On Fri, Jul 10, 2020 at 8:05 AM Hoover, Jacob via wix-devs < wix-devs at lists.wixtoolset.org> wrote:

> Convert throws a whole lot of these...
>
> error WIX0006: The whitespace preceding this node is incorrect.
>
> Why is white space in a XML document important?
>
> Also I assume this means that
> VisualStudioExtension\src\Schemas\v4\schemas\wix4.xsd is out of 
> date/not done?
>
> What switch is used w/ build to pass in a wxl?
>
> From: Rob Mensching [mailto:rob at firegiant.com]
> Sent: Thursday, July 9, 2020 4:48 PM
> To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
> Cc: Hoover, Jacob <Jacob.Hoover at greenheck.com>
> Subject: RE: Testing 4x
>
> 1. Always start with "wix convert" of your old code to new code. It 
> isn't just namespaces that change.
>
> 2. Updated documentation that shows the v4 shape of things will 
> obviously be important.
>
>
> -----Original Message-----
> From: wix-devs <wix-devs-bounces at lists.wixtoolset.org<mailto:
> wix-devs-bounces at lists.wixtoolset.org>> On Behalf Of Hoover, Jacob via 
> wix-devs
> Sent: Thursday, July 9, 2020 2:42 PM
> To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org 
> <mailto:wix-devs at lists.wixtoolset.org>>
> Cc: Hoover, Jacob <Jacob.Hoover at greenheck.com<mailto:
> Jacob.Hoover at greenheck.com>>
> Subject: Re: [wix-devs] Testing 4x
>
> If the CLI matters...
>
> Tools\build\Release\net461\win-x86>wix build Z:\Temp\Product.wxs 
> Z:\Temp\Components.wxs -o test
>
> From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On 
> Behalf Of Hoover, Jacob via wix-devs
> Sent: Thursday, July 9, 2020 4:30 PM
> To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org 
> <mailto:wix-devs at lists.wixtoolset.org>>
> Cc: Hoover, Jacob <Jacob.Hoover at greenheck.com<mailto:
> Jacob.Hoover at greenheck.com>>
> Subject: Re: [wix-devs] Testing 4x
>
> And the authoring in question is:
>
> <DirectoryRef Id="Xxx">
> <Component Id="Xxx.Directory" Guid="{...}"> <CreateFolder /> 
> <RemoveFolder Id='Xxx.Directory.Remove' On='uninstall'/> 
> <Condition>NOT UPGRADINGPRODUCTCODE</Condition> </Component> 
> </DirectoryRef>
>
> From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On 
> Behalf Of Hoover, Jacob via wix-devs
> Sent: Thursday, July 9, 2020 4:20 PM
> To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org 
> <mailto:wix-devs at lists.wixtoolset.org<mailto:wix-devs at lists.wixtoolset
> .org %3cmailto:wix-devs at lists.wixtoolset.org>>>
> Cc: Hoover, Jacob <Jacob.Hoover at greenheck.com<mailto:
> Jacob.Hoover at greenheck.com<mailto:Jacob.Hoover at greenheck.com%
> 3cmailto:Jacob.Hoover at greenheck.com>>>
> Subject: [wix-devs] Testing 4x
>
> Trying to kick the tires on the now built tools, but some things lack 
> a lot of detail, or any detail, for that matter. From the meetings I 
> could remember wix build source files..., but what are the other 
> options? Tried running against an existing installer source, and after 
> doing namespace upgrades I am now running into a strange error:
>
> error WIX0005: The Component element contains an unexpected child 
> element 'Condition'
>
>
>
> Thanks,
> Jacob
>
> ____________________________________________________________________
> WiX Toolset Developer Mailing List provided by FireGiant 
> http://www.firegiant.com/<http://www.firegiant.com><
> http://www.firegiant.com<http://www.firegiant.com>><
> http://www.firegiant.com<http://www.firegiant.com><
> http://www.firegiant.com<http://www.firegiant.com>>>
> NOTE: This email was received from an external source. Please use 
> caution when opening links or attachments in the message.
> ____________________________________________________________________
> WiX Toolset Developer Mailing List provided by FireGiant 
> http://www.firegiant.com/<http://www.firegiant.com/><
> http://www.firegiant.com/<http://www.firegiant.com/>>
> NOTE: This email was received from an external source. Please use 
> caution when opening links or attachments in the message.
> ____________________________________________________________________
> WiX Toolset Developer Mailing List provided by FireGiant 
> http://www.firegiant.com/<http://www.firegiant.com/>
> NOTE: This email was received from an external source. Please use 
> caution when opening links or attachments in the message.
> ____________________________________________________________________
> WiX Toolset Developer Mailing List provided by FireGiant 
> http://www.firegiant.com/
>
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/ ____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/