[wix-devs] 6196 - Create log for ExePackage

[Rob Mensching]

I don't think redirect console output to log should be the default value.

I take that position based on the belief that most executable Windows installations are not console applications and thus this should be only used by those (few?) that write to console.

-----Original Message-----
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of Sean Hall via wix-devs
Sent: Wednesday, July 8, 2020 5:49 AM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Cc: Sean Hall <r.sean.hall at gmail.com>
Subject: Re: [wix-devs] 6196 - Create log for ExePackage

I created a WIP for this at
https://wixtoolset.org/development/wips/6196-create-exepackage-log/. I need to know if we're going to set this as the default since that would be breaking, otherwise it could be done at any time.

On Wed, Jul 1, 2020 at 8:30 AM Bob Arnson <bob at firegiant.com> wrote:

> +1 on troubleshooting
>
> -----Original Message-----
> From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of 
> Sean Hall via wix-devs
> Sent: Tuesday, 30 June, 2020 17:51
> To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
> Cc: Sean Hall <r.sean.hall at gmail.com>
> Subject: Re: [wix-devs] 6196 - Create log for ExePackage
>
> I went with Protocol because both of the existing protocols today 
> already handle creating a log file. Adding this functionality on top 
> didn't make sense to me.
>
> The reason I think it should be the default is because I think Burn 
> should default to behavior that enables troubleshooting.
>
> On Wed, Jul 1, 2020 at 2:58 AM Rob Mensching <rob at firegiant.com> wrote:
>
> > I'm not 100% sold that Protocol attribute is the best place to put 
> > this but I'm also not sure _another_ attribute is worth it. I could 
> > be swayed either way.
> >
> > But if using protocol, I prefer the words "redirect", "console", "log"
> vs.
> > "capture" and "stream". So something more like:
> > Protocol="redirectConsoleToLog" or an attribute 
> > "RedirectConsoleToLog='yes'".
> >
> > I also don't think we should default to logging the console output.
> > Default should remain none.
> >
> > -----Original Message-----
> > From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of 
> > Sean Hall via wix-devs
> > Sent: Saturday, June 27, 2020 10:03 PM
> > To: WiX Toolset Developer Mailing List 
> > <wix-devs at lists.wixtoolset.org>
> > Cc: Sean Hall <r.sean.hall at gmail.com>
> > Subject: [wix-devs] 6196 - Create log for ExePackage
> >
> > https://github.com/wixtoolset/issues/issues/6196 is about getting 
> > Burn to capture the output and error streams from the ExePackage and 
> > writing them to a log file. Blair commented on the issue basically 
> > saying that he would like a way to opt out.
> >
> > I was thinking about implementing this as a new ExePackage/@Protocol 
> > type
> > ("captureStreams"?) and setting it as the default. The Protocol 
> > could be set to "none" to use the v3 behavior. Are there other ways 
> > we want to do this?
> > ____________________________________________________________________
> > WiX Toolset Developer Mailing List provided by FireGiant 
> > http://www.firegiant.com/
> >
> ____________________________________________________________________
> WiX Toolset Developer Mailing List provided by FireGiant 
> http://www.firegiant.com/
>
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/