[wix-devs] 6204 - Add support for high DPI to the Burn engine, Take 2

[Hoover, Jacob]

Never mind...  Read the comments...

// TODO: send value from manifest

From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On Behalf Of Hoover, Jacob via wix-devs
Sent: Tuesday, July 7, 2020 2:54 PM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Cc: Hoover, Jacob <Jacob.Hoover at greenheck.com>
Subject: Re: [wix-devs] 6204 - Add support for high DPI to the Burn engine, Take 2

Was I reading it wrong that the variable was initialized to DPIU_AWARENESS dpiuAwareness = DPIU_AWARENESS_PERMONITORV2; , but then never looked at the authoring to change it? Or am I missing a change in another PR?

From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On Behalf Of Bob Arnson via wix-devs
Sent: Tuesday, July 7, 2020 1:22 PM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org<mailto:wix-devs at lists.wixtoolset.org>>
Cc: Bob Arnson <bob at firegiant.com<mailto:bob at firegiant.com>>
Subject: Re: [wix-devs] 6204 - Add support for high DPI to the Burn engine, Take 2

Ship it.

-----Original Message-----
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org<mailto:wix-devs-bounces at lists.wixtoolset.org<mailto:wix-devs-bounces at lists.wixtoolset.org%3cmailto:wix-devs-bounces at lists.wixtoolset.org>>> On Behalf Of Sean Hall via wix-devs
Sent: Tuesday, 7 July, 2020 01:57
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org<mailto:wix-devs at lists.wixtoolset.org<mailto:wix-devs at lists.wixtoolset.org%3cmailto:wix-devs at lists.wixtoolset.org>>>
Cc: Sean Hall <r.sean.hall at gmail.com<mailto:r.sean.hall at gmail.com<mailto:r.sean.hall at gmail.com%3cmailto:r.sean.hall at gmail.com>>>
Subject: Re: [wix-devs] 6204 - Add support for high DPI to the Burn engine, Take 2

I guess it could be an enum attribute on BootstrapperApplication?
Originally I thought there might be a use case for declaring support for
PerMonitorV2 and System but not PerMonitor, but that probably doesn't make sense. The DpiAwareness attribute could be PerMonitorV2, PerMonitor, System, GdiScaled, or Unaware.

I don't know what you think is easy, here's what it could look like -
https://github.com/wixtoolset/dutil/pull/13<https://github.com/wixtoolset/dutil/pull/13><https://github.com/wixtoolset/dutil/pull/13<https://github.com/wixtoolset/dutil/pull/13>> and https://github.com/wixtoolset/burn/pull/15<https://github.com/wixtoolset/burn/pull/15><https://github.com/wixtoolset/burn/pull/15<https://github.com/wixtoolset/burn/pull/15>>. This works.

On Mon, Jul 6, 2020 at 11:33 PM Bob Arnson <bob at firegiant.com<mailto:bob at firegiant.com<mailto:bob at firegiant.com%3cmailto:bob at firegiant.com>>> wrote:

> Under BootstrapperApplication? Sounds like it could be an enum attribute.
> If it's easy, then I'm +1. Hell, +1.25!
>
> -----Original Message-----
> From: wix-devs <wix-devs-bounces at lists.wixtoolset.org<mailto:wix-devs-bounces at lists.wixtoolset.org<mailto:wix-devs-bounces at lists.wixtoolset.org%3cmailto:wix-devs-bounces at lists.wixtoolset.org>>> On Behalf Of
> Sean Hall via wix-devs
> Sent: Monday, 6 July, 2020 09:18
> To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org<mailto:wix-devs at lists.wixtoolset.org<mailto:wix-devs at lists.wixtoolset.org%3cmailto:wix-devs at lists.wixtoolset.org>>>
> Cc: Sean Hall <r.sean.hall at gmail.com<mailto:r.sean.hall at gmail.com<mailto:r.sean.hall at gmail.com%3cmailto:r.sean.hall at gmail.com>>>
> Subject: Re: [wix-devs] 6204 - Add support for high DPI to the Burn
> engine, Take 2
>
> Something like a DpiAwareness element with SupportsPMV2='yes'.
>
> If the process is declared as per-monitor DPI aware but your UI
> framework is only System DPI aware then Bad Things happen when the DPI
> isn't the primary monitor's DPI.
>
> On Mon, Jul 6, 2020, 23:03 Bob Arnson <bob at firegiant.com<mailto:bob at firegiant.com<mailto:bob at firegiant.com%3cmailto:bob at firegiant.com>>> wrote:
>
> > How are you thinking the bundle would declare DPI awareness? I'm +1
> > on the feature though I'd fully support if it were via manifest and
> > we assumed DPI awareness in a v4 BA (2020+).
> >
> > And +1 on getting rid of GDI+.
> >
> > -----Original Message-----
> > From: wix-devs <wix-devs-bounces at lists.wixtoolset.org<mailto:wix-devs-bounces at lists.wixtoolset.org<mailto:wix-devs-bounces at lists.wixtoolset.org%3cmailto:wix-devs-bounces at lists.wixtoolset.org>>> On Behalf Of
> > Sean Hall via wix-devs
> > Sent: Monday, 6 July, 2020 08:26
> > To: WiX Toolset Developer Mailing List
> > <wix-devs at lists.wixtoolset.org<mailto:wix-devs at lists.wixtoolset.org<mailto:wix-devs at lists.wixtoolset.org%3cmailto:wix-devs at lists.wixtoolset.org>>>
> > Cc: Sean Hall <r.sean.hall at gmail.com<mailto:r.sean.hall at gmail.com<mailto:r.sean.hall at gmail.com%3cmailto:r.sean.hall at gmail.com>>>
> > Subject: [wix-devs] 6204 - Add support for high DPI to the Burn
> > engine, Take 2
> >
> > In order to finish the High-DPI support for wixstdba, Burn needs to
> > declare that it is per-monitor DPI aware. As I said in the issue,
> > there's two choices - manifest or programmatically.
> > https://github.com/wixtoolset/issues/issues/6204<https://github.com/wixtoolset/issues/issues/6204><https://github.com/wixtoolset/issues/issues/6204<https://github.com/wixtoolset/issues/issues/6204>>
> >
> > I would rather do it programmatically so the Bundle can decide the
> > DPI awareness mode. Also, I was able to do everything in thmutil
> > without using
> > GDI+ so I would like to revert what was done in
> > https://github.com/wixtoolset/issues/issues/4541<https://github.com/wixtoolset/issues/issues/4541><https://github.com/wixtoolset/issues/issues/4541<https://github.com/wixtoolset/issues/issues/4541>>. Thoughts?
> > ____________________________________________________________________
> > WiX Toolset Developer Mailing List provided by FireGiant
> > http://www.firegiant.com/<http://www.firegiant.com><http://www.firegiant.com<http://www.firegiant.com>>
> >
> ____________________________________________________________________
> WiX Toolset Developer Mailing List provided by FireGiant
> http://www.firegiant.com/<http://www.firegiant.com/><http://www.firegiant.com/<http://www.firegiant.com/>>
>
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/<http://www.firegiant.com/><http://www.firegiant.com/<http://www.firegiant.com/>>
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/<http://www.firegiant.com/><http://www.firegiant.com/<http://www.firegiant.com/>>
NOTE: This email was received from an external source. Please use caution when opening links or attachments in the message.
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/<http://www.firegiant.com/>
NOTE: This email was received from an external source. Please use caution when opening links or attachments in the message.