[wix-devs] 6297 - Burn needs to do better at unregistering

[Bob Arnson]

Seems like Plan/Apply should provide feedback to the BA in that case. (Hey, S_FALSE!) Probably need to tolerate it, in the case of a stubborn package that won't uninstall -- there should still be a "best-effort" attempt to clean up what it can (again, with feedback to the BA).

-----Original Message-----
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of Sean Hall via wix-devs
Sent: Tuesday, 29 December, 2020 18:58
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Cc: Sean Hall <r.sean.hall at gmail.com>
Subject: Re: [wix-devs] 6297 - Burn needs to do better at unregistering

I've started looking at implementing this. It looks like I need to modify the proposal for how Burn decides whether to keep the ARP entry during a normal operation:

1. Burn needs to track non-permanent packages installed or anything being cached.
2. Due to non-Vital packages and rollback boundaries, Burn needs to keep track of these during Apply instead of determining it ahead of time in Plan.

This brings me to a question I had a long time ago - http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/Burn-caching-behavior-during-uninstall-td7599411.html.
Burn currently always unregisters and uncaches the bundle during Uninstall (if it succeeds), but I think the answer here is that it shouldn't actually uninstall the bundle if there will still be non-permanent packages installed or anything in the cache. That's going to break a lot of assumptions in the code, though.

On Fri, Dec 11, 2020 at 6:07 PM Sean Hall <r.sean.hall at gmail.com> wrote:

> I created a WIP for the automatic uninstalling of the bundle 
> discussion we were having in 4822 at 
> https://wixtoolset.org/development/wips/6297-cleanup-bundle-after-quit/.
> I think the interesting parts here are:
>
> 1. Under what conditions does the engine try to automatically uninstall?
> 2. When during runtime does it cleanup the bundle?
> 3. Should the BA be involved at all during this automatic behavior?
>
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/