[wix-devs] 5222 - Burn's related/dependent bundle actions should be opt-in

[Bob Arnson]

:confused pikachu face: The issue is about making the behavior opt-in; are you thinking of some other issue?

-----Original Message-----
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of Sean Hall via wix-devs
Sent: Monday, 14 December, 2020 14:43
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Cc: Sean Hall <r.sean.hall at gmail.com>
Subject: Re: [wix-devs] 5222 - Burn's related/dependent bundle actions should be opt-in

Sorry, I meant that we would keep detect and upgrade (the easy ones) and drop add-on and patch (the magic ones). If it's not complex, then why didn't you just list all of the things that needed to be addressed when you created the issue?

On Sun, Dec 13, 2020 at 5:57 PM Bob Arnson <bob at firegiant.com> wrote:

> Normally I'm the one suggesting stuff like that...
>
> We need the concept for upgrades so most of the functionality has to 
> exist. Detect-only related bundles are trivial. That leaves add-on 
> bundles and patch bundles. The implementation is mostly just a few 
> detection and state comparisons; it's not complex. There's definitely 
> some vestigial code in there, e.g., supporting old-old bundle 
> registration. We could clean it up if we were willing to break 
> compatibility with v3.x related bundles or keep it as v3.x>7.
>
> -----Original Message-----
> From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of 
> Sean Hall via wix-devs
> Sent: Sunday, 13 December, 2020 18:40
> To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
> Cc: Sean Hall <r.sean.hall at gmail.com>
> Subject: Re: [wix-devs] 5222 - Burn's related/dependent bundle actions 
> should be opt-in
>
> That's not the answer I wanted, but it was what I expected. Given that 
> there's no documentation, how many people are actually using related 
> bundles (aside from upgrades)? What if we just... pulled them from v4?
> Since I don't think anyone is really able to maintain them today and 
> there's quite a few bugs on them.
>
> On Sun, Dec 13, 2020 at 5:31 PM Bob Arnson <bob at firegiant.com> wrote:
>
> > There are specs (or were) but they never made it outside zip code 98052.
> > Of course, there's no guarantee they accurate reflect the current 
> > state of Burn, so retro-speccing from the code is probably necessary
> anyway.
> >
> > -----Original Message-----
> > From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of 
> > Sean Hall via wix-devs
> > Sent: Sunday, 13 December, 2020 17:52
> > To: WiX Toolset Developer Mailing List 
> > <wix-devs at lists.wixtoolset.org>
> > Cc: Sean Hall <r.sean.hall at gmail.com>
> > Subject: [wix-devs] 5222 - Burn's related/dependent bundle actions 
> > should be opt-in
> >
> > For https://github.com/wixtoolset/issues/issues/5222, does anyone 
> > already have the list of magic stuff that is happening today? Or is 
> > there existing documentation somewhere about related bundles so I 
> > can get an idea of how related bundles are expected to interact with 
> > each other? Is there even anybody with the knowledge to be able to 
> > create such documentation or is someone going to have to reverse 
> > engineer the code to write the documentation?
> > ____________________________________________________________________
> > WiX Toolset Developer Mailing List provided by FireGiant 
> > http://www.firegiant.com/
> >
> ____________________________________________________________________
> WiX Toolset Developer Mailing List provided by FireGiant 
> http://www.firegiant.com/
>
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/