[wix-devs] VS2017/2019 Detection Warning Property

[Christopher Painter]

I don't think this will go well bouncing back and forth via email.  I'd be happy to jump on a call if you wanted to have a friendly chat about it.


________________________________
From: Heath Stewart <heaths at outlook.com>
Sent: Tuesday, June 11, 2019 7:06 PM
To: Christopher Painter; WiX Toolset Developer Mailing List
Subject: RE: VS2017/2019 Detection Warning Property


As I said, I don’t recall that. But clearly the message is the same. That’s like asking devs to opt into default behavior.







________________________________
From: Christopher Painter <chrpai at iswix.com>
Sent: Tuesday, June 11, 2019 5:04:42 PM
To: Heath Stewart; WiX Toolset Developer Mailing List
Subject: Re: VS2017/2019 Detection Warning Property

https://github.com/wixtoolset/issues/issues/5979<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fwixtoolset%2Fissues%2Fissues%2F5979&data=02%7C01%7C%7Cc7c94ec00f0248b86c9808d6eec993d1%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636958946866085755&sdata=I3j0nPcxT5rV%2BpjJW%2FCFW84FGoAdDPiixaGr8de%2BqfM%3D&reserved=0>

Me:
Perhaps set a property to use with a launch condition to block when a problem with vs is detected. Just filtering the instance makes it seem like there is a problem with the product msi that is trying to register with visual studio.

You:
That leaves it up to the setup dev which, if ignored, negatively impacts the end user.



________________________________
From: Heath Stewart <heaths at outlook.com>
Sent: Tuesday, June 11, 2019 7:00 PM
To: WiX Toolset Developer Mailing List
Cc: Christopher Painter
Subject: RE: VS2017/2019 Detection Warning Property


I don’t remember you ever mentioning something about it. Perhaps I didn’t see a question, but I don’t recall comment on anything like that. But it wouldn’t make much sense to define a property that setup developers then have to know to use and author it in there. The CA (IIRC, it already does) should emit a warning users can see in a log at the very least, if not raise an error that manifests into a normal MSI error, but since VS is now multi-instance one could be bad while another one may be fine. What then?







________________________________
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> on behalf of Christopher Painter via wix-devs <wix-devs at lists.wixtoolset.org>
Sent: Tuesday, June 11, 2019 4:58:16 PM
To: WiX Toolset Developer Mailing List
Cc: Christopher Painter
Subject: Re: [wix-devs] VS2017/2019 Detection Warning Property

Another takeaway from that thread is a user seems to have installed SSDT (Microsoft.VisualStudio.Product.SQL) and thinks VS2017 detection in 3.14 is broken because it (allegedly) worked for him in WiX 3.11.



________________________________
From: Christopher Painter
Sent: Tuesday, June 11, 2019 9:10 AM
To: WiX Toolset Developer Mailing List
Subject: VS2017/2019 Detection Warning Property

FWD to wix-devs per Rob.     The thread referenced (removed) dealt with a user who has a corrupt 2017 installation who is strongly convinced that WiX 3.14 is broken.


________________________________
From: Rob Mensching <rob at firegiant.com>
Sent: Tuesday, June 11, 2019 8:34 AM
To: Christopher Painter; ivan.peev at gmail.com
Cc: WiX Toolset Users Mailing List
Subject: RE: [wix-users] Official 3.14 release date


That's a totally reasonable thing to bring up on wix-devs, especially given this thread.



_____________________________________________________________

Short replies here. Complete answers over there: https://eur02.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.firegiant.com%2F&data=02%7C01%7C%7Cd244b3f78e0742b53d7208d6eec8b033%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636958943048765541&sdata=GhPASZqvZ5vX6gAj4BdTF14uvvaS7LVcFkuBNiJh518%3D&reserved=0<https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.firegiant.com%2F&data=02%7C01%7C%7Cc7c94ec00f0248b86c9808d6eec993d1%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636958946866105771&sdata=WPOxw506vEJL5ci2VRZhWeNF3%2B1ABT4J6YqG7h1H0yA%3D&reserved=0>





From: Christopher Painter <chrpai at iswix.com>
Sent: Tuesday, June 11, 2019 6:18 AM
To: Rob Mensching <rob at firegiant.com>; ivan.peev at gmail.com
Cc: WiX Toolset Users Mailing List <wix-users at lists.wixtoolset.org>
Subject: Re: [wix-users] Official 3.14 release date



Rob,



 I personally would love a safety check in the code if possible.  A property such as VSANYWHEREISSUESFOUND  that I could use in a LaunchCondition to say  please check the health of your VS instances and run [ProductName] setup again.   I think I mentioned this somewhere and Heath didn't like it.  Maybe he didn't understand what I was asking for or maybe I didn't understand why he didn't like it.



Thanks,

Chris
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant https://eur02.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.firegiant.com%2F&data=02%7C01%7C%7Cd244b3f78e0742b53d7208d6eec8b033%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636958943048765541&sdata=GhPASZqvZ5vX6gAj4BdTF14uvvaS7LVcFkuBNiJh518%3D&reserved=0<https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.firegiant.com%2F&data=02%7C01%7C%7Cc7c94ec00f0248b86c9808d6eec993d1%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636958946866125787&sdata=82OCj8bxPHXZQB%2BU%2Fa7seHYkyMKgqHyCOZDYtiSyBiE%3D&reserved=0>