[wix-devs] VS2019 Preview 1 Early Preview support available

Sun Jan 20 10:32:37 PST 2019

Do whatever you want.  Personally  I'm not sorry I tested.  I'd rather find out and know about it then someone else find out about it first.  I sure didn't want there to an impression that my PR was half baked.   Either way it was more enjoyable then the two hours I just spent decluttering my bedroom.

>From my perspective the two issues / PRs are a pair.

Speaking of code signing... I noticed the VSIXs aren't signed.  The VSIX installer in VS2019 called out that it wasn't signed.  I'm not sure I've seen that before in previous versions.

And for weekly releases,  personally I like to make sure my pipeline is always valid even if I'm not planning a release.  It sure helps a lot when I have to make an unexpected release in a hurry.

________________________________
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> on behalf of Sean Hall via wix-devs <wix-devs at lists.wixtoolset.org>
Sent: Sunday, January 20, 2019 11:30 AM
To: WiX Toolset Developer Mailing List
Cc: Sean Hall
Subject: Re: [wix-devs] VS2019 Preview 1 Early Preview support available

I wasn't planning on taking that pull request until VS2019 did an RC, but
I'm not against taking it now if we want to do that.

I'm sorry you spent your time validating the build when it didn't include
everything you thought it did. We should either take the pull request, do
another release, and update the link on the Downloads page or put a
disclaimer on the Downloads page that it currently requires v3.14.

By the way, the main reason there isn't a more recent weekly build is
because our signing process has changed recently, and there just aren't
many changes being made in v3.14 right now. I think Heath is working on the
signing.

On Sun, Jan 20, 2019 at 10:48 AM Christopher Painter <chrpai at iswix.com>
wrote:

> At some point Rob asked if I would be willing to provide ongoing support
> while features are in preview and I said yes.   More recently he posted the
> VS extension and thanked me for my contribution.  I have a deep care for
> user experiences so I took the time out of my morning to download and
> validate the release using a number of configurations  just to make sure
> all was still good.
>
> The download page says:
>
>
> *WiX Toolset Visual Studio Extension* this extension provides integration
> for the WiX Toolset into Visual Studio. You will still need to install the
> WiX Toolset v3.11.1 build tools.
>
>  *New!* *Early Preview* for Visual Studio 2019 Preview 1 available for
> direct download:
>
> There is no mention of needing WiX 3.14.
>
> If your opinion is it's not unreasonable for the preview extension to only
> work with an 8 month old weekly release then great. I  just suggest the
> downloads page say that.
>
> If anyone asks why the new extension I contributed doesn't work with WiX
> 3.11.1, I'll kindly direct them to your comments.
>
>
> ------------------------------
> *From:* wix-devs <wix-devs-bounces at lists.wixtoolset.org> on behalf of
> Sean Hall via wix-devs <wix-devs at lists.wixtoolset.org>
> *Sent:* Sunday, January 20, 2019 10:19 AM
> *To:* WiX Toolset Developer Mailing List
> *Cc:* Sean Hall
> *Subject:* Re: [wix-devs] VS2019 Preview 1 Early Preview support available
>
> I answered your comment on the relevant pull request -
> https://github.com/wixtoolset/VisualStudioExtension/pull/11
>
>
> On Sun, Jan 20, 2019 at 9:36 AM Christopher Painter via wix-devs <
> wix-devs at lists.wixtoolset.org> wrote:
>
> > https://github.com/wixtoolset/issues/issues/5894
> >
> >
> >
> > chrpai<https://github.com/chrpai> commented 16 days ago<
> > https://github.com/wixtoolset/issues/issues/5894#issuecomment-451451250>
> >
> > I made a private build of Votive using @drolevar<
> > https://github.com/drolevar>'s ropos containing his msbuild pull
> request.
> > Tested VS2019 Preview 1 with WiX 3.10, 3.11 and a private build of 3.14
> and
> > all the scenarios look good to me.
> >
> >
> >
> >
> >
> > ________________________________
> > From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> on behalf of
> > Christopher Painter via wix-devs <wix-devs at lists.wixtoolset.org>
> > Sent: Sunday, January 20, 2019 9:23 AM
> > To: WiX Toolset Developer Mailing List
> > Cc: Christopher Painter
> > Subject: Re: [wix-devs] VS2019 Preview 1 Early Preview support available
> >
> > Rob,
> >
> >
> >  I just did some validations on a clean VM and there is a problem with
> > that release.  If I use wix 3.11.1 and the votive2019 I built everything
> is
> > fine.  If I use wix 3.11.1 and the Votive2019 that was just published I
> > can't create projects and I get an MSBuild error (Evaluates to "Current"
> > instead of a number )
> >
> >
> > If I extract the two vsix files I see differences in the wix.xsd.  I'm
> > guessing that PR for that other MSBuild issue wasn't included?
> >
> >
> >
> > Chris
> >
> >
> > ________________________________
> > From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> on behalf of Rob
> > Mensching via wix-devs <wix-devs at lists.wixtoolset.org>
> > Sent: Sunday, January 20, 2019 7:59 AM
> > To: WiX Toolset Developer Mailing List
> > Cc: Rob Mensching
> > Subject: [wix-devs] VS2019 Preview 1 Early Preview support available
> >
> > As discussed at the last WiX Online Meeting (
> >
> https://www.firegiant.com/blog/2019/1/17/wix-online-meeting-162-highlights/
> ),
> > I've updated wixtoolset.org releases page (
> http://wixtoolset.org/releases/)
> > to include a link to the direct download of the "Preview of WiX Toolset
> > Visual Studio 2019 Preview 1 Extension" (I considered adding another
> > "Preview" to the end but it looked a bit much).
> > WiX Online Meeting #162 Highlights - firegiant.com<
> >
> https://www.firegiant.com/blog/2019/1/17/wix-online-meeting-162-highlights/
> > >
> > www.firegiant.com<http://www.firegiant.com>
> > About FireGiant. Now you can install with confidence. FireGiant arms you
> > with accurate support from the creators of WiX. Because there are no
> > questions we can't answer or problems we can't solve, you can unleash the
> > full functionality of WiX without a doubt.
> >
> >
> >
> > WiX Online Meeting #162 Highlights - firegiant.com<
> >
> https://www.firegiant.com/blog/2019/1/17/wix-online-meeting-162-highlights/
> > >
> > www.firegiant.com<http://www.firegiant.com>
> > About FireGiant. Now you can install with confidence. FireGiant arms you
> > with accurate support from the creators of WiX. Because there are no
> > questions we can't answer or problems we can't solve, you can unleash the
> > full functionality of WiX without a doubt.
> >
> >
> >
> >
> > Thanks again to Christopher Painter for doing the heavy lifting.
> >
> > ____________________________________________________________________
> > WiX Toolset Developer Mailing List provided by FireGiant
> > http://www.firegiant.com/
> > ____________________________________________________________________
> > WiX Toolset Developer Mailing List provided by FireGiant
> > http://www.firegiant.com/
> > ____________________________________________________________________
> > WiX Toolset Developer Mailing List provided by FireGiant
> > http://www.firegiant.com/
> >
> ____________________________________________________________________
> WiX Toolset Developer Mailing List provided by FireGiant
> http://www.firegiant.com/
>
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/