[wix-devs] Are there plans to upgrade the dtf to use later features of C#

[Heath Stewart]

Specific to your example, if your interest is an ICollection or ICollection<T> you do not want to use Any(). In the .NET Framework that allocates a new enumerable every time. .NET Core changed theirs to try-cast to either of those interfaces first to avoid that. Perf gains are measurable. I inquired about doing that for Framework, but they are adverse to any behavior changes for fear of regressions. Using Count == 0 is better.

- Heath (mobile)

________________________________
From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> on behalf of Christopher Painter via wix-devs <wix-devs at lists.wixtoolset.org>
Sent: Wednesday, April 17, 2019 3:45:46 PM
To: WiX Toolset Developer Mailing List
Cc: Christopher Painter
Subject: Re: [wix-devs] Are there plans to upgrade the dtf to use later features of C#

It would depend on which projects right? Microsoft.deployment.windowsinstaller vs bits that only get called during build time.

Sent from my iPhone

> On Apr 17, 2019, at 5:36 PM, Rob Mensching via wix-devs <wix-devs at lists.wixtoolset.org> wrote:
>
> Unless there is a really good reason, DTF should keep targeting .NET Framework 2.0. That provides extremely broad adoption with essentially no cost, unless the code becomes impossible to maintain. ".Count == 0" vs ".Any()" isn't a deal breaker. <smile/>
>
>
> -----Original Message-----
> From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of Sean Farrow via wix-devs
> Sent: Wednesday, April 17, 2019 12:52 PM
> To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
> Cc: Sean Farrow <sean.farrow at seanfarrow.co.uk>
> Subject: [wix-devs] Are there plans to upgrade the dtf to use later features of C#
>
> Hi,
>
> Whilst looking at the dtf code earlier today, I noticed sevarl uses (0articularly in the makesfxca) of the following patter:
>
> If (inputs.Count ==0)
>
> This leads me to wonder whether there are plans to upgrade the .Net code to use things like Linq's Any operator?
>
> I'm happy to raise an issue to look at things like this through out the codebase if it were required.
>
> Also, what is the minimum .Net Framework Wix V4 is planning to support?
> Kind regards
> jSean.
> ____________________________________________________________________
> WiX Toolset Developer Mailing List provided by FireGiant https://eur04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.firegiant.com%2F&data=02%7C01%7C%7C50fd43b73748486a9aaf08d6c3867437%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636911379569684831&sdata=VLc%2BmQec37r%2BfHJ3PHmhUI3zWo82uOVN%2BrrZaQ%2FfymY%3D&reserved=0
> ____________________________________________________________________
> WiX Toolset Developer Mailing List provided by FireGiant https://eur04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.firegiant.com%2F&data=02%7C01%7C%7C50fd43b73748486a9aaf08d6c3867437%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636911379569684831&sdata=VLc%2BmQec37r%2BfHJ3PHmhUI3zWo82uOVN%2BrrZaQ%2FfymY%3D&reserved=0
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant https://eur04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.firegiant.com%2F&data=02%7C01%7C%7C50fd43b73748486a9aaf08d6c3867437%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636911379569684831&sdata=VLc%2BmQec37r%2BfHJ3PHmhUI3zWo82uOVN%2BrrZaQ%2FfymY%3D&reserved=0